Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a limit on Vulkan command buffer size #67

Open
HadrienG2 opened this issue Jun 25, 2024 · 1 comment
Open

Set a limit on Vulkan command buffer size #67

HadrienG2 opened this issue Jun 25, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@HadrienG2
Copy link
Owner

Right now, the Vulkan versions can submit arbitrarily large command buffers to the GPU, because it just packs all simulation steps to be processed into a single command buffer.

However, it has been observed that the NVidia Linux driver encounters performance issues when processing very large command buffers, and that the AMD Linux driver can encounter correctness issues in the same scenario. Furthermore, too big a command buffer could potentially result in a desktop freeze or a system GPU watchdog kill, depending on if GPU preemption is implemented between command buffers or individual dispatches. For all these reasons, it would be a good idea to limit the size of command buffers to a certain amount of commands, and emit multiple command buffers after this limit is reached.

This will require modifying the abstract simulation trait to use impl GpuFuture instead of a concrete type in a strategic location.

@HadrienG2 HadrienG2 added the bug Something isn't working label Jun 25, 2024
@HadrienG2
Copy link
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant