Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation: Link type 'movie' -> 'video' #87

Open
deejam opened this issue Jul 17, 2019 · 4 comments
Open

Translation: Link type 'movie' -> 'video' #87

deejam opened this issue Jul 17, 2019 · 4 comments

Comments

@deejam
Copy link

deejam commented Jul 17, 2019

Movie is a type of video.

Change [link type 'movie' not supported] -> [link type 'video' not supported]

@humdingerb
Copy link
Member

It looks like that kind of 'type' is officially named "movie". So it may be that this is the correct terminology wrt PDFs.

@deejam
Copy link
Author

deejam commented Jul 17, 2019

It looks like that kind of 'type' is officially named "movie". So it may be that this is the correct terminology wrt PDFs.

According to PDF 32000-1:2008, Movie (13.4) is obsolete and replaced with Multimedia (13.2):

The features described in this sub-clause are obsolescent and their use is no longer recommended. They are superseded by the general multimedia framework described in 13.2, “Multimedia.”

Multimedia can be of any arbitrary media type (audio, video, image) (13.2.1, NOTE 1).

@humdingerb
Copy link
Member

Alright then, "video" it is...

@deejam
Copy link
Author

deejam commented Jul 19, 2019

While making a change for this issue, I noticed that the movie annotation (and several others) are not used.

# UNUSED resource(91, "ANNOT_MOVIE") #'VICN' array {

BePDF/bepdf/beos/PDFView.cpp

Lines 1463 to 1464 in eccc789

// TODO
case actionMovie: // fall through

BePDF/bepdf/beos/PDFView.cpp

Lines 1645 to 1648 in eccc789

case actionMovie:
// TODO
s = B_TRANSLATE("[link type 'movie' not supported]");
break;

That explains why there were so many annotations that I could not find in BePDF while translating.

Maybe it is better to comment out all the B_TRANSLATE calls for unused annotations. That way, they will be removed from Polyglot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants