Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current source checkout fails with a parse error on gcc2 #375

Open
Begasus opened this issue Jul 22, 2020 · 3 comments
Open

Current source checkout fails with a parse error on gcc2 #375

Begasus opened this issue Jul 22, 2020 · 3 comments

Comments

@Begasus
Copy link

Begasus commented Jul 22, 2020

This is with: https://github.com/adamfowleruk/Paladin/blob/develop/Paladin/PreviewFeatures/CommandOutputHandler.h#L29

https://paste.ubuntu.com/p/YPfQTXsdtp/

EDIR Stripping "override" on that line fixes the build (but I'm pretty sure it's not the correct sollution ;)

-	virtual void							MessageReceived(BMessage* msg) override;
+	virtual void							MessageReceived(BMessage* msg);
@Begasus
Copy link
Author

Begasus commented Jul 22, 2020

On another not "-lgcov" is gcc8 only afaik: https://github.com/adamfowleruk/Paladin/blob/44887d1fea2a3b3cecf0878dbc531ff09b850630/Tests/compile.sh#L11
Tests are OK on gcc2 without -lgcov there also

@kenmays
Copy link

kenmays commented Jul 24, 2020

Fixed for Haikuports PR. Patch provided there.

@adamfowleruk
Copy link
Collaborator

Thanks for this. I'll ensure that my build testing uses x86 in the pipeline in future. Should catch things like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants