Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Tray icon language doesn't follow config #4281

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Fix] Tray icon language doesn't follow config #4281

wants to merge 1 commit into from
+45 −3

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Jan 16, 2025 •
edited
Loading

This PR fixes 2 issues:

  • The TrayIcon was listening to the wrong event to re-render the context menu, it was listening for the event to change the language (before the change) and not an event AFTER the change. Because of that it was always showing the old language when changed. This adds that new event so it's updated at the right time.
  • Another problem was that we were NOT storing the language setting in the backend when changed, only in the frontend, so, after a restart, the language in the backend was always en while the frontend had the correct value (frontend language is stored in the chrome store). I added that fix so the TrayIcon shows the correct language when started.

One thing I didn't include was updating the backend value with the frontend value cause it's not really that critical, users can just change language after this and it will be corrected.

Closes #4279

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jan 16, 2025
@arielj arielj requested review from Etaash-mathamsetty, a team, flavioislima, CommandMC, Nocccer and imLinguin and removed request for a team January 16, 2025 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Etaash-mathamsetty Etaash-mathamsetty Awaiting requested review from Etaash-mathamsetty

@flavioislima flavioislima Awaiting requested review from flavioislima flavioislima was automatically assigned from Heroic-Games-Launcher/development

@CommandMC CommandMC Awaiting requested review from CommandMC CommandMC was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

@imLinguin imLinguin Awaiting requested review from imLinguin imLinguin was automatically assigned from Heroic-Games-Launcher/development

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translation of tray resets to English after restarting Heroic.
1 participant
@arielj