Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid Steam shortcuts generated (wrong target executable). #4325

Open
Magicrafter13 opened this issue Feb 4, 2025 · 2 comments
Open

Invalid Steam shortcuts generated (wrong target executable). #4325

Magicrafter13 opened this issue Feb 4, 2025 · 2 comments
Labels
bug:unconfirmed Someone works on identifying the issue

Comments

@Magicrafter13
Copy link

Describe the bug

I go to launch a game from Steam, and it goes "Play" -> "Running" -> "Play rather quickly.

When I check the shortcut that's been made I can see the executable as /usr/lib/electron34/electron, and the arguments as --no-gui --no-sandbox "heroic://launch/legendary/63a665088eb1480298f1e57943b225d8". If I then open a terminal and run this same command, I get the following output:

Error launching app
Unable to find Electron app at /home/matthew/heroic:/launch/legendary/63a665088eb1480298f1e57943b225d8

Cannot find module '/home/matthew/heroic:/launch/legendary/63a665088eb1480298f1e57943b225d8'

So it would seem that the arguments being generated are invalid/incomplete.

I have a Steam shortcut generated with an older version of Heroic which runs /opt/heroic/heroic --no-gui --no-sandbox "heroic://launch/legendary/Boga", which doesn't work as heroic is not located there anymore it seems. If I change this to a correct executable path (/usr/bin/heroic) it does launch from the command line. Likewise, if I then modify the first game mentioned (the Steam shortcut made with the current version of Heroic) to point to /usr/bin/heroic instead of electron, the game now launches from Steam.

If I had to guess, Heroic makes the wise choice not to assume the location of its binary but rather to try to programmatically determine it, but something in that process doesn't work correctly.

Add logs

I don't see any relevant information here, but;

(12:58:59) INFO:    [Legendary]:        Legendary location: /usr/lib/heroic/app.asar.unpacked/build/bin/x64/linux/legendary

(12:58:59) INFO:    [Gog]:              GOGDL location: /usr/lib/heroic/app.asar.unpacked/build/bin/x64/linux/gogdl

(12:58:59) INFO:    [Connection]:       Connectivity: check-online

(12:58:59) INFO:    [Connection]:       Pinging external endpoints

(12:58:59) INFO:    [Gog]:              Checking for existing gog manifests

(12:58:59) WARNING: [Backend]:          Failed to register protocol with OS.

(12:58:59) INFO:    [Legendary]:        Running command: LEGENDARY_CONFIG_PATH=/home/matthew/.config/heroic/legendaryConfig/legendary /usr/lib/heroic/app.asar.unpacked/build/bin/x64/linux/legendary --version

(12:58:59) INFO:    [Gog]:              Running command: GOGDL_CONFIG_PATH=/home/matthew/.config/heroic/gogdlConfig /usr/lib/heroic/app.asar.unpacked/build/bin/x64/linux/gogdl --auth-config-path /home/matthew/.config/heroic/gog_store/auth.json --version

(12:58:59) INFO:    [Nile]:             Running command: NILE_CONFIG_PATH=/home/matthew/.config/heroic/nile_config /usr/lib/heroic/app.asar.unpacked/build/bin/x64/linux/nile --version

(12:59:00) INFO:    [Connection]:       Connectivity: online

(12:59:00) ERROR:   [Gog]:              Unable to syncQueued playtime, userData not present

(12:59:00) INFO:    [Gog]:              Running command: GOGDL_CONFIG_PATH=/home/matthew/.config/heroic/gogdlConfig /usr/lib/heroic/app.asar.unpacked/build/bin/x64/linux/gogdl --auth-config-path /home/matthew/.config/heroic/gog_store/auth.json auth

(12:59:00) INFO:    [Backend]:          

System Information:

CPU: 24x AMD Ryzen 9 7900X 12-Core Processor

Memory: 100.27 GB (used: 57.13 GB)

GPUs:

  GPU 0:

    Name: Advanced Micro Devices, Inc. [AMD/ATI] Raphael

    IDs: D=164e V=1002 SD=364e SV=1849

    Driver: amdgpu

  GPU 1:

    Name: Advanced Micro Devices, Inc. [AMD/ATI] Navi 31 [Radeon RX 7900 XT/7900 XTX/7900 GRE/7900M]

    IDs: D=744c V=1002 SD=7905 SV=1eae

    Driver: amdgpu

OS: EndeavourOS 6.12.10-arch1-1 (linux)

The current system is not a Steam Deck

We are not running inside a Flatpak container

Software Versions:

  Heroic: 2.15.2 Emeth

  Legendary: 0.20.36 Urban Flight (Heroic)

  gogdl: 1.1.2

  comet: comet 0.1.2

  Nile: 1.1.2 Will A. Zeppeli

(12:59:00) INFO:    [Frontend]:         Refreshing undefined Library

(12:59:00) WARNING: [Backend]:          refresh not implemented on Sideload Library Manager

(12:59:00) INFO:    [Legendary]:        Refreshing library...

(12:59:00) INFO:    [Legendary]:        Refreshing Epic Games...

(12:59:00) INFO:    [Backend]:          Frontend Ready

(12:59:00) INFO:    [Backend]:          Checking for new Heroic Updates

(12:59:00) INFO:    [Backend]:          Checking for current version changelog

(12:59:00) INFO:    [Legendary]:        Running command: LEGENDARY_CONFIG_PATH=/home/matthew/.config/heroic/legendaryConfig/legendary /usr/lib/heroic/app.asar.unpacked/build/bin/x64/linux/legendary list --third-party

(12:59:00) INFO:    [Backend]:          AreWeAntiCheatYet data downloaded

(12:59:02) INFO:    [Legendary]:        Game list updated, got 196 games & DLCs

(12:59:02) INFO:    [Winetricks]:       Downloading Winetricks

(12:59:02) WARNING: [Backend]:          listUpdateableGames not implemented on Sideload Library Manager

(12:59:02) INFO:    [Legendary]:        Checking for game updates: LEGENDARY_CONFIG_PATH=/home/matthew/.config/heroic/legendaryConfig/legendary /usr/lib/heroic/app.asar.unpacked/build/bin/x64/linux/legendary list --third-party

(12:59:02) INFO:    [Legendary]:        Checking if EOS Overlay is enabled: LEGENDARY_CONFIG_PATH=/home/matthew/.config/heroic/legendaryConfig/legendary /usr/lib/heroic/app.asar.unpacked/build/bin/x64/linux/legendary eos-overlay info --prefix "/home/matthew/Games/Heroic/Prefixes/default/Marvels Guardians of the Galaxy/pfx"

(12:59:02) INFO:    [ExtraGameInfo]:    Using cached ExtraGameInfo data for Marvels Guardians of the Galaxy

(12:59:02) DEBUG:   [Legendary]:        Using cached install info

(12:59:02) INFO:    [ExtraGameInfo]:    Using cached ExtraGameInfo data for Marvels Guardians of the Galaxy

(12:59:02) DEBUG:   [Legendary]:        Using cached install info

(12:59:02) DEBUG:   [Legendary]:        Using cached install info

(12:59:02) INFO:    [Legendary]:        Abort command "LEGENDARY_CONFIG_PATH=/home/matthew/.config/heroic/legendaryConfig/legendary /usr/lib/heroic/app.asar.unpacked/build/bin/x64/linux/legendary eos-overlay info --prefix "/home/matthew/Games/Heroic/Prefixes/default/Marvels Guardians of the Galaxy/pfx""

(12:59:03) WARNING: [Legendary]:        Game with AppName 5bf67f3153364181b54cb9e40ca7fa82 is installed but was not found on account

(12:59:03) INFO:    [Legendary]:        Found 0 games to update

(12:59:03) DEBUG:   [Legendary]:        Using cached install info

(12:59:03) DEBUG:   [Legendary]:        Using cached install info

(12:59:04) INFO:    [WineDownloader]:   Updating wine versions info

(12:59:04) INFO:    [WineDownloader]:   Fetching upstream information...

(12:59:05) INFO:    [Backend]:          Starting the Download Queue

(12:59:05) INFO:    [WineDownloader]:   wine versions updated

(12:59:05) INFO:    [Shortcuts]:        Remove Steam images for Marvel's Guardians of the Galaxy

(12:59:05) INFO:    [Shortcuts]:        Marvel's Guardians of the Galaxy was successfully removed from Steam.

(12:59:06) INFO:    [ExtraGameInfo]:    Using cached ExtraGameInfo data for Marvels Guardians of the Galaxy

(12:59:06) INFO:    [Shortcuts]:        Prepare Steam images for Marvel's Guardians of the Galaxy

(12:59:06) INFO:    [Shortcuts]:        Marvel's Guardians of the Galaxy was successfully added to Steam.

(12:59:07) DEBUG:   [Legendary]:        Using cached install info

(12:59:08) DEBUG:   [Legendary]:        Using cached install info

Steps to reproduce

  1. Install heroic-games-launcher from the AUR, or just checkout version 2.15.2 and build it yourself.
  2. Launch Heroic
  3. Select a game (in my case Guardians of the Galaxy)
  4. In the 3-dot drop-down click "Add to Steam"
  5. Restart Steam
  6. Right click game in Steam and click "Properties..."
  7. Observe TARGET field set to "/usr/lib/electron34/electron"

Expected behavior

Heroic correctly sets the target executable for the Steam shortcut.

Screenshots

No response

Heroic Version

Latest Stable

System Information

  • OS: EndeavourOS (Arch Linux)

Additional information

The current AUR package builds from git+https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher.git#tag=v2.15.2.
@Magicrafter13 Magicrafter13 added the bug:unconfirmed Someone works on identifying the issue label Feb 4, 2025
@jokysatria
Copy link

I have the same issue.

@jobukkit
Copy link

Yes, Steam cannot launch Heroic games anymore on Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug:unconfirmed Someone works on identifying the issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jobukkit @Magicrafter13 @jokysatria