Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more robust error handling for the model construction #151

Open
5 tasks
jlperla opened this issue Aug 4, 2022 · 0 comments
Open
5 tasks

Add more robust error handling for the model construction #151

jlperla opened this issue Aug 4, 2022 · 0 comments

Comments

@jlperla
Copy link
Member

jlperla commented Aug 4, 2022

The symbolic generation tools have very few checks to help debug model specification errors. These could be added as checks in the code with appropriate unit tests in https://github.com/HighDimensionalEconLab/DifferentiableStateSpaceModels.jl/blob/v0.4.19/test/make_perturbation_model.jl

The checks shoudl be added around https://github.com/HighDimensionalEconLab/DifferentiableStateSpaceModels.jl/blob/v0.4.19/src/make_perturbation_model.jl#L43-L55

Some ones that might be very helpful are:

  • Ensure that p, y, x have no overlapping symbols
  • Ensure that all uses of y and x are with the function notation so that the all_to_markov etc. will pass
  • Ensure that there are no symbols in H that are not contained in y,x,p
  • Ensure that there are no symbols in Γ, Ω, steady_states , steady_states_iv that are not contained in the p. I don't think that the y,x are allowed in those, but doublecheck.
  • Make a few extra mistakes like having the wrong number of equations/etc. and see what the errors are.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant