Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Allow a transform to define the file extensions it supports #535

Open
1 of 2 tasks
daw3rd opened this issue Aug 23, 2024 · 0 comments
Open
1 of 2 tasks
Assignees
Labels
enhancement New feature or request

Comments

@daw3rd
Copy link
Member

daw3rd commented Aug 23, 2024

Search before asking

  • I searched the issues and found no similar issues.

Component

Library/core

Feature

We have binary transforms that generally need to be configured (using --data_files_to_use cli param) to specify the extensions of the files to which the transform can be applied. This means the transform can essentially fail to process any files if the user/caller does not set this command line argument.

To address this, it would be good if the transform itself could specify the extensions it supports in the associated DataAccess/Factory. This is probably most easily accomplished for the developer by setting the extensions somewhere in the TransformConfiguraiton class. It would be good to avoid having to do this in the RuntimeConfiguration class, as 1) this is cumbersome for the developer and 2) would have to be done for each runtime.

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@daw3rd daw3rd added the enhancement New feature or request label Aug 23, 2024
@daw3rd daw3rd assigned daw3rd and unassigned blublinsky Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants