Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature ideas #17

Open
Paarmita opened this issue May 8, 2020 · 4 comments
Open

New feature ideas #17

Paarmita opened this issue May 8, 2020 · 4 comments

Comments

@Paarmita
Copy link
Member

Paarmita commented May 8, 2020

As we plan to extend this Side Navigation, I suggest we can have the listed features in order to make it more flexible.

  • Add an Active state, so the user knows on which list item he/she is currently on.
  • Add 2 different icons for closing and opening the list(currently, we have 1 and rotating it 90 deg for the other state), so the user can have the option to add different icons according to the theme.
  • Also, the user should have the flexibility to add new icons for open and closed states.
  • In the mobile view, the user should be able to change the icon and color to close and open the drawer.

Group 6

@Marvin9
Copy link
Member

Marvin9 commented May 9, 2020

First one is already there. Once they click on any navigation item, Link will be redirected to their defined Route.

  • Other 2 is good, @divyanshu-rawat What if we add them in upcoming versions. Any suggestion?

@divyanshu-rawat
Copy link
Member

@Marvin9 yes we will add them in upcoming versions, but @Marvin9 by 1stt one she means like the selected one should have an active state, for example, see this one https://trendmicro-frontend.github.io/react-sidenav/, selected one here have an active state, so if we select buttons inside the atoms then buttons should keep on highlighted because it is the selected one. got it?

@Marvin9
Copy link
Member

Marvin9 commented May 9, 2020

Got it. So we need to add active style in theme option too.

@divyanshu-rawat
Copy link
Member

exactly! 🎯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants