Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new method, PEP8 #9

Open
kraigu opened this issue Oct 13, 2015 · 2 comments
Open

Added new method, PEP8 #9

kraigu opened this issue Oct 13, 2015 · 2 comments

Comments

@kraigu
Copy link

kraigu commented Oct 13, 2015

I've made a series of commits to my fork that make the code PEP8 compliant, and which add a new method get_all_networks(). Wasn't sure how best to send you a pull request, cherrypicking would be difficult because I suck at being other-dev friendly in git, but I can just send you one and you can trust me, or have a look yourself?

@igor-feoktistov
Copy link
Contributor

Send me the code. I'll review and put it on master branch.

  From: Mike <[email protected]>

To: Infoblox-Development/Infoblox-API-Python [email protected]
Sent: Tuesday, October 13, 2015 6:13 AM
Subject: [Infoblox-API-Python] Added new method, PEP8 (#9)

I've made a series of commits to my fork that make the code PEP8 compliant, and which add a new method get_all_networks(). Wasn't sure how best to send you a pull request, cherrypicking would be difficult because I suck at being other-dev friendly in git, but I can just send you one and you can trust me, or have a look yourself?—
Reply to this email directly or view it on GitHub.

@kraigu
Copy link
Author

kraigu commented Oct 13, 2015

I have it all in my fork at:
https://github.com/kraigu/Infoblox-API-Python

One problem with get_all_networks() is it only gets all v4 networks. :|

Mike

On 13 Oct 2015, at 11:15, Igor Feoktistov [email protected] wrote:

Send me the code. I'll review and put it on master branch.

From: Mike [email protected]
To: Infoblox-Development/Infoblox-API-Python [email protected]
Sent: Tuesday, October 13, 2015 6:13 AM
Subject: [Infoblox-API-Python] Added new method, PEP8 (#9)

I've made a series of commits to my fork that make the code PEP8 compliant, and which add a new method get_all_networks(). Wasn't sure how best to send you a pull request, cherrypicking would be difficult because I suck at being other-dev friendly in git, but I can just send you one and you can trust me, or have a look yourself?—
Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants