Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to ES6 #12

Open
Akxe opened this issue Aug 8, 2017 · 3 comments
Open

Upgrading to ES6 #12

Akxe opened this issue Aug 8, 2017 · 3 comments

Comments

@Akxe
Copy link
Contributor

Akxe commented Aug 8, 2017

I would be also very good to use new ES6 syntax, it could upgrade performance in many cases. Improve number of needed modules, and would bring new features.

() => {} functions to stop from binding this to self
Promise to remove dependency on waterfall
Map has forEach method, could give you easy aliasing for hostnames
const, let to specify scopes and usage
and probably many more

@Irrelon
Copy link
Owner

Irrelon commented Aug 9, 2017

This is true, having it written with ES6 would be nice, but I challenge the part about performance... the gains (if any) would probably be so small as to make the rewrite pointless unless we are missing a feature in ES5 that we desperately need and is only available in ES6.

I'm not against ES6 per-se, just that if it's not broken, don't fix it comes to mind :)

@Akxe
Copy link
Contributor Author

Akxe commented Aug 9, 2017

Loading many libraries can be intense for small server machines, I agree that for normal computer it doesn't really change that much, but for raspberry pi server, it could change a lot.

I can rewrite most of it to es6, but the certbot is problem for me as I don't know what it is. If you want me to rewrite it I can look onto it and create a pull afterwards.

@Irrelon
Copy link
Owner

Irrelon commented Aug 9, 2017

Certbot is letsencrypt for cli.

@Akxe Akxe mentioned this issue Aug 10, 2017
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants