Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autoscale and group scale to undo/redo history #275

Closed
Xewar313 opened this issue Mar 28, 2024 · 0 comments
Closed

Add autoscale and group scale to undo/redo history #275

Xewar313 opened this issue Mar 28, 2024 · 0 comments
Milestone

Comments

@Xewar313
Copy link

Currently, autoscale and group scale actions are not stored in history, and we would like to be able to undo/redo them.

Most problems stem from the fact that group scale is calculated once, basing on initially provided tracks, and after track removal and undoing their removal we may not have all tracks to properly recalculate the scale.
There are also some bugs with removing some part of grouped tracks that could result in scale deadlocking on calculation.

Current changes include addition of dedicated commands, and caching previous results that could allow them to be readded after undoing the action. However, I suspect that the simplest and best solution would be to completely redesign how group scales are implemented, so that they are more atomic and less dependent on some unseen global state

@iromeo iromeo added this to the JBR 2.0 milestone Apr 16, 2024
@iromeo iromeo closed this as completed Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants