Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autosave peaks annotations and do not lose them (re-open) after browser or jvm crash / computer restart #42

Open
iromeo opened this issue May 24, 2018 · 5 comments
Assignees

Comments

@iromeo
Copy link
Contributor

iromeo commented May 24, 2018

At the moment if browser crash peaks could be lost, let's save them to cache so as not to miss anything

@iromeo iromeo changed the title Cache Annotator peaks and re-open if browser fails Cache Annotator peaks and re-open them after browser crashe May 28, 2018
@iromeo iromeo changed the title Cache Annotator peaks and re-open them after browser crashe Cache Annotator peaks and do not lose them (re-open) after browser crashe May 28, 2018
@olegs
Copy link
Contributor

olegs commented Jun 1, 2018

I think we should focus on avoiding any crashes rather than making everything super-persistent.

@iromeo
Copy link
Contributor Author

iromeo commented Jun 8, 2018

Focus is good, but peak annotating is manual time consuming operation, for better user experience we need autosave. E.g. we cannot avoid JVM crash or just computer power failure.

@iromeo iromeo changed the title Cache Annotator peaks and do not lose them (re-open) after browser crashe Autosave peaks annotations and do not lose them (re-open) after browser or jvm crash / computer restart Jun 8, 2018
@iromeo iromeo self-assigned this Jun 8, 2018
@olegs olegs transferred this issue from another repository Mar 22, 2019
@dievsky
Copy link

dievsky commented Mar 25, 2021

Moreover, it's totally not obvious that the annotations are not saved to the exported session. We should warn the user about it at the very least.

@iromeo
Copy link
Contributor Author

iromeo commented Apr 7, 2021

Maybe let’s implement session autosave and include annotated peaks into session?

@dievsky
Copy link

dievsky commented Apr 7, 2021

You mean, include the peaks themselves in the session? Potentially, there can be a lot of them. Our annotations are about 500 records long, as far as I remember.

Also, I would suggest to ask the user on startup whether they want to load the previous autosaved session or to start from scratch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants