Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor PeaksAnnotatorTest and remove DesktopGenomeBrowser dependency #48

Open
iromeo opened this issue Nov 13, 2018 · 1 comment
Open

Refactor PeaksAnnotatorTest and remove DesktopGenomeBrowser dependency #48

iromeo opened this issue Nov 13, 2018 · 1 comment
Assignees
@iromeo

Comments

@iromeo
Copy link
Contributor

iromeo commented Nov 13, 2018

Refactor PeaksAnnotatorTest and remove DesktopGenomeBrowser dependency. DesktopGenomeBrowser isn't good for tests because it's usage could result in No X11 DISPLAY variable was set, but this program performed an operation which requires it. errors. Also, existing example provokes other developers to repeat this pattern. So refactor test and PeaksAnnotator storage + make DesktopGenomeBrowser.frame not lazy in order to force all tests using DesktopGenomeBrowser to fail with No X11 DISPLAY variable was set, but this program performed an operation which requires it. immediately.
@iromeo iromeo self-assigned this Nov 13, 2018
@dievsky
Copy link

dievsky commented Nov 13, 2018

Note also that TrackView.about currently requires a DesktopGenomeBrowser, so it would be hard to test.

@olegs olegs transferred this issue from another repository Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iromeo iromeo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iromeo @dievsky