Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: Rename to emoji-blast #168

Closed
3 tasks done
JoshuaKGoldberg opened this issue Sep 3, 2023 · 9 comments · Fixed by #171 or #560
Closed
3 tasks done

🚀 Feature: Rename to emoji-blast #168

JoshuaKGoldberg opened this issue Sep 3, 2023 · 9 comments · Fixed by #171 or #560
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: feature New enhancement or request 🚀

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Sep 3, 2023 •
edited
Loading

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

I love the name "emojisplosion". I really do. But it's hard to remember or type and is probably harming the success of the package 😞. A simpler name like "emoji-blast" would probably be more widely findable...

Additional Info

I'll think about this for a bit.
@JoshuaKGoldberg JoshuaKGoldberg added the type: feature New enhancement or request 🚀 label Sep 3, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Sep 3, 2023
@JoshuaKGoldberg JoshuaKGoldberg added the status: needs investigation Further research required...? 🔎 label Sep 3, 2023
@JoshuaKGoldberg
Copy link
Owner Author

Yeah I'm going to go for it.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Sep 22, 2023
Merged
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg changed the title 🚀 Feature: Consider renaming to emoji-blast 🚀 Feature: Rename to emoji-blast Sep 22, 2023
@JoshuaKGoldberg JoshuaKGoldberg added accepting prs and removed status: needs investigation Further research required...? 🔎 labels Sep 22, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Sep 22, 2023
Open
@jaas666
Copy link

jaas666 commented Dec 2, 2023

Curious as to why you didn't merge #171. Looks like it would to close this issue?
Change of heart about the name change or something else?

@JoshuaKGoldberg
Copy link
Owner Author

Ha, good question. My last few months have been mostly swamped with a combination of higher priority projects and traveling. I'd wanted to get to the renaming of this project & others once I have some dedicated time on my home setup. Hopefully by the end of this month (2023)!

@jaas666
Copy link

jaas666 commented Dec 2, 2023

So in the end the name will be konami-emoji-blast?
All that's needed is to change the PR you already opened to konami-emoji-blast' instead of emoji-blast`?

If that's the case I can try taking that off your plate if you want .

@JoshuaKGoldberg
Copy link
Owner Author

It's a bit more than that I'm afraid: #172. I don't really want to go through the hassle of renaming all these individual packages if some of that work is duplicated/unnecessary in a move to a monorepo.

If you're looking for contribution opportunities for emojisplosion (😍!), #1 might be a good place to go. Or failing that, #129 or #135.

@jaas666
Copy link

jaas666 commented Dec 2, 2023 via email

@JoshuaKGoldberg JoshuaKGoldberg added status: blocked Waiting for something else to be resolved 🙅 and removed accepting prs labels Mar 27, 2024
@JoshuaKGoldberg
Copy link
Owner Author

I'll tackle this after #188.

@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! 🙏 and removed status: blocked Waiting for something else to be resolved 🙅 labels Mar 28, 2024
@JoshuaKGoldberg
Copy link
Owner Author

@all-contributors please add @JoshuaKGoldberg for ideas.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@allcontributors AllContributors
Copy link
Contributor

@JoshuaKGoldberg

We had trouble processing your request. Please try again later.

JoshuaKGoldberg added a commit that referenced this issue Mar 28, 2024
@JoshuaKGoldberg
feat: rename to emoji-blast (#171)
c7848cc 
## PR Checklist

- [x] Addresses an existing open issue: fixes #168 
- [x] That issue was marked as [accepting
prs](https://github.com/JoshuaKGoldberg/emojisplosion/issues?q=is%3Aopen+is%3Aissue+label%3A%22accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/emojisplosion/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Also overhauls the README.md flow a bit, renames `easy` to `now`, and
adds more info in the demo pages.

Lowers the version to `0.9.0` so I can play with it a while before going
back to `1.x` / stable.
@github-actions github-actions bot mentioned this issue Aug 10, 2024
Merged
JoshuaKGoldberg added a commit that referenced this issue Aug 10, 2024
@JoshuaKGoldberg
Version Packages (#560)
705965c 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## [email protected]

### Patch Changes

-   a88b14f: patch bump for tooling

### Bug Fixes

- add missing pnpm build:dist to release.yml
([8ef426b](8ef426b))
- ensure window width and height are defined
([#42](#42))
([979069e](979069e))
- remove console.log
([97ef4f3](97ef4f3))
- remove unsupported default emojis
([#196](#196))
([d283303](d283303)),
closes [#194](#194)

### Features

- added events option with onClick
([#137](#137))
([714fb8e](714fb8e))
- rename to emoji-blast
([#171](#171))
([c7848cc](c7848cc)),
closes [#168](#168)
- updated default emojis list for 2023
([#138](#138))
([c0d096a](c0d096a))

## [email protected]

### Patch Changes

-   a88b14f: patch bump for tooling
-   Updated dependencies [a88b14f]
    -   [email protected]
    -   [email protected]
    -   @konami-emoji-blast/[email protected]

## [email protected]

### Patch Changes

-   a88b14f: patch bump for tooling
-   Updated dependencies [a88b14f]
    -   [email protected]

## @konami-emoji-blast/[email protected]

### Patch Changes

-   a88b14f: patch bump for tooling
-   Updated dependencies [a88b14f]
    -   [email protected]

## @konami-emoji-blast/[email protected]

### Patch Changes

-   a88b14f: patch bump for tooling
-   Updated dependencies [a88b14f]
    -   [email protected]
    -   [email protected]

## @konami-emoji-blast/[email protected]

### Patch Changes

-   a88b14f: patch bump for tooling
-   Updated dependencies [a88b14f]
    -   [email protected]

## @konami-emoji-blast/[email protected]

### Patch Changes

-   a88b14f: patch bump for tooling
-   Updated dependencies [a88b14f]
    -   [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: feature New enhancement or request 🚀
Projects
None yet
Milestone
No milestone
2 participants
@JoshuaKGoldberg @jaas666