Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: Switch from optimist (deprecated) to yargs #86

Closed
altano opened this issue Apr 1, 2024 · 5 comments · Fixed by #94
Closed

🚀 Feature: Switch from optimist (deprecated) to yargs #86

altano opened this issue Apr 1, 2024 · 5 comments · Fixed by #94
Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: feature New enhancement or request 🚀

Comments

@altano
Copy link

altano commented Apr 1, 2024

We don't need to get into a conversation about whether warnings like this are helpful or not, but they are happening.

My latest one was from pulling in eslint-plugin-package-json, because of this dependency chain:

eslint-plugin-package-json 0.12.0
└─┬ package-json-validator 0.6.3
  └─┬ optimist 0.6.1
    └── minimist 0.0.10

It looks like package-json-validator would benefit from either moving from optimist (deprecated) to directly using an updated version of minimist or switching to something like yargs.
@de-don
Copy link
Contributor

de-don commented May 23, 2024

+1

@JoshuaKGoldberg
Copy link
Owner

Oop, sorry for the delay! Agreed. Using deprecated dependencies isn't good.

Per https://www.npmjs.com/package/optimist:

I don't want to maintain this module anymore since I just use minimist, the argument parsing engine, directly instead nowadays.

See yargs for the modern, pirate-themed successor to optimist.

minimist does a good bit less than what this currently uses optimist for. So I'd say let's move to yargs. 👍 accepting PRs!

@JoshuaKGoldberg JoshuaKGoldberg added type: feature New enhancement or request 🚀 status: accepting prs Please, send a pull request to resolve this! 🙏 labels Jul 11, 2024
@JoshuaKGoldberg JoshuaKGoldberg changed the title dependabot warnings about package 🚀 Feature: Switch from optimist (deprecated) to yargs Jul 11, 2024
de-don added a commit to de-don/package.json-validator that referenced this issue Sep 12, 2024
@de-don
feat: migrate to yargs
7ad1c6b 
closes JoshuaKGoldberg#86
@de-don de-don mentioned this issue Sep 12, 2024
Merged
de-don added a commit to de-don/package.json-validator that referenced this issue Sep 12, 2024
@de-don
feat: migrate to yargs
5d12509 
closes JoshuaKGoldberg#86
@de-don
Copy link
Contributor

de-don commented Sep 12, 2024

@JoshuaKGoldberg I have opened PR, please check it :)

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Sep 12, 2024 •
edited
Loading

Great! I get a notification for every comment, issue, and PR in this repo - so any PR that gets sent effectively tags me. I'll look soon!

de-don added a commit to de-don/package.json-validator that referenced this issue Oct 16, 2024
@de-don
fix: mark options as boolean
e5052c2 
closes JoshuaKGoldberg#86
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 17, 2024 •
edited by JoshuaKGoldberg
Loading

🎉 This is included in version v0.7.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: feature New enhancement or request 🚀
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: migrate to yargs de-don/package.json-validator
3 participants
@altano @JoshuaKGoldberg @de-don