Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation #159

Open
simonbyrne opened this issue Apr 22, 2019 · 5 comments
Open

Documentation #159

simonbyrne opened this issue Apr 22, 2019 · 5 comments

Comments

@simonbyrne
Copy link
Member

The documentation of this package leaves a lot to be desired. Some ideas:

  • Split it up into obvious sections (perhaps along the lines of the DLMF)
  • Document the domains/where the function is defined
  • Add external links (Wikipedia and DLMF are the obvious ones to link to).
  • References to implementations
  • Add plots
@Sumegh-git
Copy link
Contributor

I'll do some of this work this weekend if not earlier. Also where should these changes be done? The domains and ext. links can be done in the function docstring where they are defined. What about plots?

@simonbyrne
Copy link
Member Author

I don't think it is possible to have docs in docstrings, they would have to go into the markdown files. I have some code I'll post.

@PaulXiCao
Copy link
Contributor

I'd like to help out here.
Have you got any special layout in mind? I'd just create sections along DLMF and then a subsection for each function (sorted alphabetically).
Each function would be described in the same manner: domain+links(wikipedia/DLMF)+plots [optinally: implementation details+todos].

What are thoughts on it?

@simonbyrne
Copy link
Member Author

@PaulXiCao That would be fantastic. I would encourage you to start with small incremental changes and we can go from there.

@PaulXiCao
Copy link
Contributor

@simonbyrne I just uploaded the first two documentations about erf, and erfc. I'd be happy for some more input.

My thoughts this far:

  1. Section names according to DLMF but no further subsectioning except one for each function. For me this seems enough at first .
  2. I didnt add any more explanations or plots bc i think nobody really cares. Doesnt just everybody go to wikipedia for further informations?
  3. What do you think about the layout? Very basic but is it enough or did you have something fancier in mind?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants