Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submission of "extra" files no longer works #2662

Open
bradking opened this issue Jan 15, 2025 · 5 comments · May be fixed by #2663
Open

Submission of "extra" files no longer works #2662

bradking opened this issue Jan 15, 2025 · 5 comments · May be fixed by #2663
Assignees
@josephsnyder
Labels
bug report

Comments

@bradking
Copy link
Member

The ctest --extra-submit <file> option allows uploading arbitrary files to CDash. Since #2437 was deployed on open.cdash.org, this no longer works. Similarly, CMake's CTestTest2 test, which tests submitting extra files, now fails with:

CURL output: [{"status":1,"description":"Could not determine submission file type for: 'inbox\/PublicDashboard_-__-_6534cae9-ee7e-4daf-b476-fc7bdab66510_-_3d9205f5fe06ff6f43bba6f739b3903c.xml'"}]
@josephsnyder josephsnyder self-assigned this Jan 15, 2025
@josephsnyder
Copy link
Member

Thanks for the report, @bradking. I'll look to make that unknown file type not an error if the system isn't set up for rejecting the submit if the validation fails.

@williamjallen
Copy link
Collaborator

Just to clarify things, the only change here is that errors which were previously being sent to the logs are now returned to the client.

@bradking
Copy link
Member Author

For reference, the ctest --extra-submit option was added in 2005 by CMake commit f47a57c3e8. That predates CDash, and so perhaps was meant for the old Dart or Dart '2' based dashboards.

@zackgalbreath
Copy link
Contributor

I've back out this change on open.cdash.org and my.cdash.org while we figure out the best way to proceed.

@bradking
Copy link
Member Author

I've opened CMake Issue 26611 to consider deprecating this ctest feature.

josephsnyder added a commit that referenced this issue Jan 15, 2025
@josephsnyder
Account for non-xml submission objects
1738624 
When given a non-xml submission file, catch the exception of the bad
submission and only reject the submission of the Validate setting is enabled.

Fixes: #2662
@josephsnyder josephsnyder linked a pull request Jan 15, 2025 that will close this issue
Open
josephsnyder added a commit that referenced this issue Jan 15, 2025
@josephsnyder
Account for non-xml submission objects
7101072 
When given a non-xml submission file, catch the exception of the bad
submission and only reject the submission of the Validate setting is enabled.

Fixes: #2662
josephsnyder added a commit that referenced this issue Jan 15, 2025
@josephsnyder
Account for non-xml submission objects
0f93331 
When given a non-xml submission file, catch the exception of the bad
submission and only reject the submission of the Validate setting is enabled.

Fixes: #2662
josephsnyder added a commit that referenced this issue Jan 15, 2025
@josephsnyder
Account for non-xml submission objects
ab9abfd 
When given a non-xml submission file, catch the exception of the bad
submission and only reject the submission of the Validate setting is enabled.

Fixes: #2662
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josephsnyder josephsnyder

Labels
bug report
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Account for non-xml submission objects Kitware/CDash
4 participants
@bradking @zackgalbreath @josephsnyder @williamjallen