-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support release rollback #1028
Comments
Sure, welcome to join us! |
kusion release rollback --revision=[num] Which of these two methods do you think is better? |
I think out of these two,
cc @liu-hm19 |
I thought about a few points and wanted to discuss it. What is our positioning of the rollback behavior? Is it different from the normal apply? Will a new release version be generated? Or is it just a rollback version, parallel to the release version? role. We must think about these designs in advance before we can proceed with code development. |
@riven-blade Well, what we expect for the If you have any different thoughts on the |
For reference implementation, I would suggest you guys take a look at |
I looked through the code logic of helm rollback. It found the previousRelease version and generated a targetRelease based on it, and then changed currentRelease -> targetRelease. In our scenario, our apply deployment will have some parameters - -yes, detail, diff, etc., are they needed in rollback? |
@riven-blade I think during the execution of |
Okay, I'm doing it now. I'll make a first version first. In the design of helm, I understand that it has almost no terminal interaction. We have more terminal interaction in apply. I took a rough look at its rollback and packaged the old version release into a target release, deploy. |
What would you like to be added?
support release rollback, i.e. kusion apply with specified release
Why is this needed?
rollback to the last success release quickly
The text was updated successfully, but these errors were encountered: