Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Accurate Dependencies #387

Open
aidan-epperly opened this issue Jul 21, 2020 · 2 comments
Open

More Accurate Dependencies #387

aidan-epperly opened this issue Jul 21, 2020 · 2 comments

Comments

@aidan-epperly
Copy link
Member

It has occurred to me that we are reliant on a number of d3 related repositories such as d3-simple-slider and d3-tip, but this is not reflected in the dependency graph. We may want to find a way to explicitly tell github that we use these things. I don't think the cdn (#34) affects this at all, but I think the dependency graph is a good thing to keep in mind for the future.

@LRWeber
Copy link
Member

LRWeber commented Jul 21, 2020

GitHub interprets dependencies based on requirement/manifest files.
https://docs.github.com/en/github/visualizing-repository-data-with-graphs/about-the-dependency-graph#supported-package-ecosystems
Maybe there's some kind of file that is independent of any package manager that would still allow us to note such dependencies?

@LRWeber
Copy link
Member

LRWeber commented Aug 7, 2020

Technically, we could make a package.json file as used for npm to include this info. There would be no purpose to running any npm commands, but it would at least document the additional packages.

This could also open up the possibility of additional linters etc beyond just the python packages we use now.

On a related note, we should probably include python dependencies for both production and development in order to include the linters we are actively using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants