Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/24 add a title to the spinner image #28

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Feature/24 add a title to the spinner image #28

merged 2 commits into from
Nov 3, 2023

Conversation

lemke-ethan
Copy link
Contributor

  • replace hidden text in the loading spinner with an title element
  • added aria labels for additional browser support

@lemke-ethan lemke-ethan self-assigned this Oct 20, 2023
@lemke-ethan lemke-ethan linked an issue Oct 20, 2023 that may be closed by this pull request
add a title to the spinner image #24
Closed
@lemke-ethan lemke-ethan merged commit 9195f80 into main Nov 3, 2023
@lemke-ethan lemke-ethan deleted the feature/24-add-a-title-to-the-spinner-image branch November 17, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TCaprioli TCaprioli TCaprioli approved these changes

@sam-mfb sam-mfb Awaiting requested review from sam-mfb

@mfbzn mfbzn Awaiting requested review from mfbzn

Assignees

@lemke-ethan lemke-ethan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add a title to the spinner image
2 participants
@lemke-ethan @TCaprioli