Fix modernizr build when using customTests key with custom test files #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
5 similar comments
|
+1 |
|
+1 |
|
+1 |
|
+1 |
|
+1 |
|
@doctyper what is the status of this PR? Is there anything we can do to help this get merged? |
|
Modernizr team: @aFarkas @bobthecow @doctyper @KuraFire @patrickkettner @paulirish @ryanseddon @SlexAxton @stucox |
|
I just had a child, so I have been offline to care for him. I'll be back to open source in the middle of next week. |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall update to fix #22, the ability to add custom test from the user scripts, handle npm version 3 flat directories and update test suite.
Custom tests can be defined with or without the
.jsextension. Path must start from the root of the project;Sorry for mixing fixes but I needed all it to make it work on my computer.