-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to auth api usage for github for 100X traffic support #41
Comments
Yes, I do. But that would require having API keys, which is unsafe if we keep them openly on the client side. But if we don't want to do that, then its another headache to let a user login to get access to his API keys to make the calls via his ID. Without a proper server infrastructure, I suggest we close this! |
|
Because even one run of the cron job can lead to more than 60 calls in one go. Assume 10 tracked GH repos, 100 users, it is highly likely that more than 60 calls will be made. |
With https://api.github.com/users/:user/events in hand, it beats me why are we going for repo-specific search - where the list/count of repositories will always be incomprehensive. From the user's public events, we filter out only the ones performed on Possible, we might or might not require ALL that we need. But for the time being, this appears to be good enough. Plus, always remember - these are to be done with a daemon & not by Frontend with AJAX calls. So, consider the advantages/pitfalls according to that. |
We looked into it. But it doesn't show the entire history, so lets say I have a 6 month old commit, it will not turn up using the API call. |
@debloper The solution you are proposing requires minimum of #users calls (which itself can be more than 60) on top of that, the API is paginated, so we will not get everything in one page, while the solution we are following requires maximum of #users * # repos calls but a minimum of only #repos calls. Even then, as said by @sankha93 above, the users API does not give every commit. |
Right now, the limit is 60 calls per hour. If we switch to auth api calls, we can have 5000/hr. I think Sankha has an idea on how to do this..
The text was updated successfully, but these errors were encountered: