-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit-Dialog #74
Labels
Comments
TimPietrusky
added a commit
that referenced
this issue
Oct 2, 2018
In order to use the fixture-detail-view to edit it's properties it was necesarray to also save the properties into the store. This makes it possible to also rerender to the last values when editing another fixture. Also it's now possible to edit all properties and meta data of the fixture. Fixes #80, #8, #74
TimPietrusky
pushed a commit
that referenced
this issue
Jun 10, 2019
# 1.0.0 (2019-06-10) ### Bug Fixes * **animation:** Don't set useless keyframes ([2f2ff8f](2f2ff8f)) * **build:** BasePath should be / and not esm-bundled ([5ac84dd](5ac84dd)), closes [#79](#79) * **channel-grid:** Removed ducktape code ([40ce991](40ce991)) * **config:** Clean & working ([bf6621f](bf6621f)) * **config:** Working config ([33805b0](33805b0)) * **dekk:** sceneNames must be an Array ([a382973](a382973)) * **dekk-manager:** Get state from store ([3c32f8c](3c32f8c)) * **directive:** React to "undefined" String ([c0625d9](c0625d9)) * **dmx:** Use hiRes instead of multiRange ([c0d015c](c0d015c)) * **error-handling:** promise resolving ([1856a91](1856a91)) * **error-handling:** stable promise construct ([ef4d6de](ef4d6de)) * **everything:** Fixed everything with batches ([0ccf403](0ccf403)) * **fivetwelve:** Get universe from store ([55e866b](55e866b)) * **fixture:** Attempt to fix [#11](#11) ([86be373](86be373)) * **fixture:** Initialize fixture in live mode ([f19e7f7](f19e7f7)), closes [#17](#17) * **fixture:** Remove fixture from scene and universe ([7353b27](7353b27)), closes [#45](#45) * **fixture:** Renamed CameoFlatPar1RGBW ([441b8a1](441b8a1)) * **fixture:** Set property ([a96225d](a96225d)), closes [#19](#19) * **fixture:** The properties are loaded from the store ([e58a02e](e58a02e)), closes [#80](#80) [#8](#8) [#74](#74) * **fixture-manager:** Reload dmx fixture properties ([1b83e56](1b83e56)), closes [#11](#11) * **keyframe:** Use Math.round ([2daae65](2daae65)), closes [#18](#18) * **keyframe-grid:** Make all keyframes visible via scroll ([5f31813](5f31813)) * **localStorage:** Unique identifier ([f3c71fc](f3c71fc)) * **luminave:** Build & merge fix ([8bdcab6](8bdcab6)) * **luminave-server:** Set correct default URL ([a70350c](a70350c)) * **menu:** Don't close menu on page reload ([8d540d7](8d540d7)) * **midi:** Handle MIDI connect in every situation ([31900e4](31900e4)), closes [#14](#14) [#15](#15) * **midi-manager:** Connection status & remove listener ([4c57a48](4c57a48)), closes [#68](#68) [#69](#69) * **modv-integration:** Listen on 0.0.0.0 ([bf8d444](bf8d444)) * **polymer-redux:** Fixed dependency ([2f23fe3](2f23fe3)) * **polymerx:** Remove unused service worker ([d664255](d664255)) * **port:** use correct port ([2757712](2757712)) * **property:** Fixed type ([b339350](b339350)) * **scene:** Reset fixture when removing animation ([4573ee7](4573ee7)), closes [#35](#35) * **scene-bee:** Show name of scene in input ([b0923e8](b0923e8)) * **server:** Fix port definition to be ':1337' by default ([c018052](c018052)) * **state:** fix activate loop ([5e97a95](5e97a95)) * **state:** set channels on universes ([7fc96b4](7fc96b4)) * **state:** Set correct fixture properties ([0cdda5b](0cdda5b)), closes [#34](#34) * **style:** Remove unused character ([31bd519](31bd519)) * **thorium:** Listen for scene changes in the store ([4808523](4808523)) * **timeline:** Animation is not defined ([0a54bd4](0a54bd4)) * **timeline:** Check for NaN ([bb56fc1](bb56fc1)) * **timeline:** Don't trigger another loop ([2f0495e](2f0495e)), closes [#23](#23) * **timeline:** fix local duration ([7304e79](7304e79)) * **timeline:** modvColor is not used when scene gets removed ([941dff8](941dff8)), closes [#95](#95) * **timeline:** Moved progress into animation ([53a3100](53a3100)) * **timeline:** Reset timeline for animation ([62a9c3c](62a9c3c)), closes [#28](#28) * **timeline:** Updated animation is refelected in timeline ([bf960d3](bf960d3)), closes [#36](#36) * **usb-dmx-controller:** Only send universe when connected ([9456396](9456396)) * **usb-dmx-manager:** Disconnect on error ([1a2cebc](1a2cebc)) * **usb-dmx-manager:** Port is null ([5abdbbc](5abdbbc)), closes [#40](#40) * **usb-dmx-manager:** USB connection status across browsers ([f76f9ea](f76f9ea)), closes [#40](#40) * **webusb:** Set initial data to 0 ([3f9ccdf](3f9ccdf)), closes [#32](#32) ### chore * **cleanup:** Remove go server ([5e567ef](5e567ef)) * **upgrade:** Use Polymer 3 ([b77c60e](b77c60e)) ### Code Refactoring * **components:** Use PolymerElement & lit-html ([ed809c8](ed809c8)) ### Features * **activity:** scenes can be active ([f317db0](f317db0)) * **animation:** Add keyframes based on fixture properties ([7f95ed3](7f95ed3)), closes [#50](#50) * **animation:** animation-bee and addKeyframe ([3e39bb1](3e39bb1)) * **animation:** Convert keyframes to keytime ([d9aaf90](d9aaf90)) * **animation:** Headline ([73e4820](73e4820)) * **animation:** Set animation name ([db39700](db39700)) * **animation:** Set name of animation ([d7b6688](d7b6688)) * **animation-manager:** Add multiple animations ([7bf9d2a](7bf9d2a)) * **animations:** add animation to layer ([57b94ab](57b94ab)) * **animations:** Added animation-manager ([4a09a2f](4a09a2f)) * **animations:** added animations from config ([3619fc5](3619fc5)) * **app:** added timeline ([decafb0](decafb0)) * **buffer:** Added browser-version of buffer ([86b645f](86b645f)) * **client:** added polymer ([cde6559](cde6559)) * **client:** styling ([8e8a745](8e8a745)) * **color-grid:** Added row & column labels ([03bc937](03bc937)) * **components:** added connect button ([578e4b7](578e4b7)) * **components:** added inputs ([c347ca4](c347ca4)) * **components:** added timeline item ([86aed87](86aed87)) * **components:** channel-grid ([f817964](f817964)) * **components:** channel-grid config ([50098e3](50098e3)) * **components:** channel-grid IDs ([f39f0dc](f39f0dc)) * **components:** grid component event handler ([11dd852](11dd852)) * **config:** 1...2...3(0) Feierei ([73be830](73be830)) * **config:** Added config-manager ([860104f](860104f)) * **config:** config loader ([17672a8](17672a8)) * **config:** JSFest 2018 ([b6db375](b6db375)) * **config:** VisionLordConfig example ([fde823e](fde823e)) * **configuration:** Added the integration-configuration component ([fdac5cb](fdac5cb)), closes [#101](#101) * **connections:** Test usb & bluetooth connect buttons ([855d8fa](855d8fa)) * **constant:** Moved global lists into constants ([509d33f](509d33f)) * **dekk:** Added dekk-manager ([a251efe](a251efe)) * **dotjs2018:** Added fixtures ([0dc78f0](0dc78f0)), closes [#91](#91) * **fivetwelve:** Integration is configurable ([d1a9625](d1a9625)) * **fivetwelve:** Send universe to fivetwelve ([4ced96b](4ced96b)), closes [#20](#20) * **fixture:** Add / reset fixtures ([f64d255](f64d255)) * **fixture:** Added BasicColor ([4cb3058](4cb3058)) * **fixture:** Added BasicRGBDimmer ([420c395](420c395)) * **fixture:** Added id ([d78f344](d78f344)) * **fixture:** Added labels to addFixture ([e91ffee](e91ffee)) * **fixture:** Added Stairville Outdoor Stage Par Tri ([e43bf73](e43bf73)) * **fixture:** Added UV property ([450511d](450511d)) * **fixture:** Basic Fluter for JSConfEU ([cf520c5](cf520c5)) * **fixture:** Change address ([aabfd1d](aabfd1d)) * **fixture:** Check for integer ([4aa6f24](4aa6f24)) * **fixture:** Remove fixture from everywhere ([c7c577b](c7c577b)) * **fixture:** Reset fixture properties ([d5e1101](d5e1101)) * **fixture:** Set fixture properties ([a2630f1](a2630f1)) * **fixture:** Set name ([bc4134c](bc4134c)) * **fixture:** Transformed into VisionLord style ([13f50cf](13f50cf)) * **fixture:** UI improvements ([3f5c6a3](3f5c6a3)) * **fixture-detail:** Edit a fixture in it's own view ([325b68b](325b68b)), closes [#74](#74) * **fixture-manager:** Add bulk of fixtures ([f50370f](f50370f)) * **fixture-manager:** Create a Fixture Manager ([55a14b8](55a14b8)) * **fixtures:** Added dmx fixtures ([dbf9ff8](dbf9ff8)) * **fixtures:** Added dmx fixtures ([e54cbae](e54cbae)) * **flex:** Added style ([ad83d2e](ad83d2e)) * **general-view:** Move general things to a main view ([3e9660d](3e9660d)) * **graphql:** Interact with luminave-server via GraphQL ([eaa31a7](eaa31a7)) * **graphql:** Subscribe to data from luminave-server ([eb64bfc](eb64bfc)) * **history:** Added history ([aaa7209](aaa7209)) * **integration:** Added dekk integration ([383e3e8](383e3e8)) * **integration:** GraphQL via Apollo ([c8deef1](c8deef1)), closes [#101](#101) * **integration:** Separated configuration from websocket connection ([50b2801](50b2801)) * **integration-configuration:** Status emoji ([f2858e0](f2858e0)) * **jsconfeu-2019:** Everything we need for JSConfEU 2019 ([8bff32a](8bff32a)) * **jsfest:** Added fixture ([1fde1f7](1fde1f7)) * **keyframe:** Add keyframe to state ([d7b5ed6](d7b5ed6)) * **keyframe:** Select property from FIXTURE_PROPERTIES ([8bd890c](8bd890c)) * **keyframes:** Add and show keyframes ([31d8793](31d8793)) * **keytime:** Interpolate MultiRangeParam ([175778f](175778f)), closes [#6](#6) * **live:** Added live mode ([5f43b4d](5f43b4d)) * **logo:** Added Glitch Logo ([100bf2b](100bf2b)) * **luminave-server:** Added action, reducer, selector & constants ([cd8af1c](cd8af1c)) * **luminave-server:** Added subscription ([7448ab9](7448ab9)), closes [#100](#100) * **luminave-server:** Default integration via GraphQL ([b616b9a](b616b9a)), closes [#100](#100) * **midi:** Add multiple scenes to MIDI ([005baca](005baca)) * **midi:** Add scene to MIDI ([d8e4a21](d8e4a21)) * **midi:** Add scene to timeline ([aecdae8](aecdae8)) * **midi:** Added midi-controller ([8320606](8320606)) * **midi:** Added midi-manager ([04aed38](04aed38)) * **midi:** Change background while learning ([32e620e](32e620e)) * **midi:** Learn midi & midi-grid ([7bc144c](7bc144c)) * **midi:** Show list of scenes ([8e0770c](8e0770c)) * **midi:** Visualize active MIDI button ([52ca542](52ca542)) * **midi-manager:** Add custom MIDI controls ([9795fbc](9795fbc)) * **midiController:** Update the name, io & layout ([9839fa5](9839fa5)), closes [#90](#90) * **modv:** Added new mapping component ([61404eb](61404eb)) * **modv:** Connect to modV ([e22bffe](e22bffe)), closes [#10](#10) * **modv:** Custom event "received-data-from-modv" ([37c1492](37c1492)) * **modv:** Display colors in correct order ([1a78751](1a78751)) * **modv:** Get the x & y of grabCanvas ([5d65b57](5d65b57)) * **modv:** Handle multiple colors ([6c349c2](6c349c2)), closes [#42](#42) * **modv:** Listen for data from modV ([b85d486](b85d486)) * **modv:** Show icon when connected ([2002934](2002934)) * **redux:** Added selectors ([b93e17a](b93e17a)) * **ruhrjs:** Added fixtures ([b2c1682](b2c1682)), closes [#82](#82) * **scene:** Add multiple fixtures ([d00ac3b](d00ac3b)) * **scene:** Added scene-bee component ([fd81fa6](fd81fa6)) * **scene:** Set name & duration ([1c2af4d](1c2af4d)) * **scene:** Set name of scene ([246a01d](246a01d)) * **scene:** Show list of animations ([b958e3e](b958e3e)) * **scene:** Show list of fixtures ([4deb703](4deb703)) * **scene-manager:** Assign fixtures and animations while creation ([2caa88b](2caa88b)) * **scene-manager:** Remove animation + fixture in multi-add ([60dfcfd](60dfcfd)), closes [#72](#72) * **scenes:** Added run button ([e486f02](e486f02)) * **scenes:** Added scenes ([5b597d7](5b597d7)) * **selector:** Is timeline playing? ([b5bd2af](b5bd2af)) * **server:** Make server port configurable ([61ffe7f](61ffe7f)) * **sort:** Correct Natural Sort for Arrays ([0e85b95](0e85b95)) * **state:** Added redux-thunk ([a07bf0e](a07bf0e)) * **state:** Integrate old components ([e591f74](e591f74)) * **state:** New version of polymer-redux ([a746916](a746916)) * **state:** polymer-redux state example ([949ae71](949ae71)) * **storage:** Added storage-manager ([fadf35b](fadf35b)) * **storage:** Download storage ([bac2e7d](bac2e7d)) * **storage:** Print the current storage ([2fc04d8](2fc04d8)) * **style:** Links ([be643cb](be643cb)) * **theme:** Added a dark-theme and improved UI ([06d48bd](06d48bd)) * **thorium:** Dynamic animation ([7c4218c](7c4218c)), closes [#100](#100) [#99](#99) * **thorium:** Improved handling scenes & animations ([4acf689](4acf689)), closes [#100](#100) * **timeline:** add labels on keyframes ([57407be](57407be)) * **timeline:** add play button ([17782e7](17782e7)) * **timeline:** added simple progress ([450c550](450c550)) * **timeline:** Combined all components & made timeline infinite ([f4079f9](f4079f9)), closes [#61](#61) * **timeline:** Dynamic scenes ([d0af262](d0af262)), closes [#100](#100) * **timeline:** Handle scenes in a timeline ([e6a3a04](e6a3a04)) * **timeline:** Infinite part 2 ([6c88bc5](6c88bc5)), closes [#16](#16) * **timeline:** Play scenes in a loop ([aedd2a9](aedd2a9)) * **timeline:** Remove scene + fixtures from timeline ([65ba643](65ba643)) * **timeline:** Remove scenes from timeline ([bc715b9](bc715b9)) * **timeline:** Reset universe and fixtures ([ef2a1ec](ef2a1ec)), closes [#24](#24) * **timeline:** return values of animation ([1c255c8](1c255c8)) * **timeline:** Start playback with space ([d763809](d763809)) * **timeloop:** added simple timeloop ([8377a7a](8377a7a)) * **universe:** Add & remove universes ([bf4e7b4](bf4e7b4)) * **universe:** Reset universe ([b1927df](b1927df)) * **universe:** Set channel for universe ([eaab59d](eaab59d)) * **universe:** Set channel for universe ([d8ac840](d8ac840)) * **usb-manager:** Moved USB classes to usb-manager ([202fffd](202fffd)) * **util:** toFixedNumber ([58859fa](58859fa)) * **uuid:** Generate real UUID v1 ([a0ced76](a0ced76)) * **venue:** Added venues ([1dd0b8e](1dd0b8e)), closes [#53](#53) * **venue:** Automatically add matching fixture to slot ([0bb255b](0bb255b)) ### Performance Improvements * **everything:** Optimazations for performance ([9d34915](9d34915)), closes [#37](#37) [#22](#22) * **fixture:** Set all fixture properties at once ([ddda6b0](ddda6b0)) * **fixtures:** Improved performance ([cbb3d44](cbb3d44)) * **modv:** modV in global object ([9d1753a](9d1753a)) ### BREAKING CHANGES * **upgrade:** Use Polymer 3.0.0 and not 3.0.0-pre.1 * **cleanup:** Removed go server * **components:** Every component uses lit-html * **client:** new frontend
TimPietrusky
pushed a commit
that referenced
this issue
Jul 19, 2019
# [3.1.0](v3.0.0...v3.1.0) (2019-07-19) ### Bug Fixes * **animation:** Don't set useless keyframes ([2f2ff8f](2f2ff8f)) * **build:** BasePath should be / and not esm-bundled ([5ac84dd](5ac84dd)), closes [#79](#79) * **directive:** React to "undefined" String ([c0625d9](c0625d9)) * **fixture:** The properties are loaded from the store ([e58a02e](e58a02e)), closes [#80](#80) [#8](#8) [#74](#74) * **keyframe-grid:** Make all keyframes visible via scroll ([5f31813](5f31813)) * **luminave:** Build & merge fix ([8bdcab6](8bdcab6)) * **luminave-server:** Set correct default URL ([a70350c](a70350c)) * **menu:** Don't close menu on page reload ([8d540d7](8d540d7)) * **polymerx:** Remove unused service worker ([d664255](d664255)) * **style:** Remove unused character ([31bd519](31bd519)) * **thorium:** Listen for scene changes in the store ([4808523](4808523)) * **timeline:** Animation is not defined ([0a54bd4](0a54bd4)) * **timeline:** Check for NaN ([bb56fc1](bb56fc1)) * **timeline:** modvColor is not used when scene gets removed ([941dff8](941dff8)), closes [#95](#95) ### Features * **animation:** Add keyframes based on fixture properties ([7f95ed3](7f95ed3)), closes [#50](#50) * **config:** 1...2...3(0) Feierei ([73be830](73be830)) * **configuration:** Added the integration-configuration component ([fdac5cb](fdac5cb)), closes [#101](#101) * **dotjs2018:** Added fixtures ([0dc78f0](0dc78f0)), closes [#91](#91) * **fivetwelve:** Integration is configurable ([d1a9625](d1a9625)) * **fixture:** Added BasicRGBDimmer ([420c395](420c395)) * **fixture-detail:** Edit a fixture in it's own view ([325b68b](325b68b)), closes [#74](#74) * **general-view:** Move general things to a main view ([3e9660d](3e9660d)) * **graphql:** Interact with luminave-server via GraphQL ([eaa31a7](eaa31a7)) * **graphql:** Subscribe to data from luminave-server ([eb64bfc](eb64bfc)) * **integration:** GraphQL via Apollo ([c8deef1](c8deef1)), closes [#101](#101) * **integration:** Separated configuration from websocket connection ([50b2801](50b2801)) * **integration-configuration:** Status emoji ([f2858e0](f2858e0)) * **jsconfeu-2019:** Everything we need for JSConfEU 2019 ([8bff32a](8bff32a)) * **luminave-server:** Added action, reducer, selector & constants ([cd8af1c](cd8af1c)) * **luminave-server:** Added subscription ([7448ab9](7448ab9)), closes [#100](#100) * **luminave-server:** Default integration via GraphQL ([b616b9a](b616b9a)), closes [#100](#100) * **midiController:** Update the name, io & layout ([9839fa5](9839fa5)), closes [#90](#90) * **modv:** Added new mapping component ([61404eb](61404eb)) * **modv:** Get the x & y of grabCanvas ([5d65b57](5d65b57)) * **modv:** Listen for data from modV ([b85d486](b85d486)) * **ruhrjs:** Added fixtures ([b2c1682](b2c1682)), closes [#82](#82) * **selector:** Is timeline playing? ([b5bd2af](b5bd2af)) * **style:** Links ([be643cb](be643cb)) * **thorium:** Dynamic animation ([7c4218c](7c4218c)), closes [#100](#100) [#99](#99) * **thorium:** Improved handling scenes & animations ([4acf689](4acf689)), closes [#100](#100) * **timeline:** Combined all components & made timeline infinite ([f4079f9](f4079f9)), closes [#61](#61) * **timeline:** Dynamic scenes ([d0af262](d0af262)), closes [#100](#100) * **timeline:** Infinite part 2 ([6c88bc5](6c88bc5)), closes [#16](#16) * **util:** toFixedNumber ([58859fa](58859fa)) * **venue:** Added venues ([1dd0b8e](1dd0b8e)), closes [#53](#53) * **venue:** Automatically add matching fixture to slot ([0bb255b](0bb255b))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue Description
Instead of having all the fields that are necessary to update an entity in every view, we want an edit button that opens an edit dialog!
The text was updated successfully, but these errors were encountered: