Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Amazon Cognito OAuth2.0 authentication #3094

Open
joshika39 opened this issue Jan 20, 2025 · 3 comments
Open

Introduce Amazon Cognito OAuth2.0 authentication #3094

joshika39 opened this issue Jan 20, 2025 · 3 comments
Labels
enhancement New feature or request

Comments

@joshika39
Copy link
Contributor

Hey there!

I want to implement the support for Amazon Cognito OAuth2.0.

They have a proper OAuth2.0 flow implemented, when you use Cognito as an IDP:

@joshika39 joshika39 added the enhancement New feature or request label Jan 20, 2025
@rmmayo
Copy link
Collaborator

rmmayo commented Jan 20, 2025

Hello @joshika39 - we are not very familiar with Amazon Cognito, but you are welcome to submit a PR for consideration.

You may or may not be aware, but SkillTree already supports some OAuth 2.0 providers. Please see: https://skilltreeplatform.dev/dashboard/install-guide/config.html#oauth-support-pass-auth-mode-only

It's possible you may only need to implement an OAuth2UserConverter for Amazon Cognito, please see: https://github.com/NationalSecurityAgency/skills-service/blob/master/service/src/main/java/skills/auth/form/oauth2/OAuth2UserConverterService.groovy

Lastly, please adhere to our contribution guidelines: https://skilltreeplatform.dev/contribution/

Good luck!

@joshika39
Copy link
Contributor Author

joshika39 commented Jan 20, 2025

Thanks! I saw the source code already, found where to put what, and am looking into what tests I have to write.

Also, I saw, that you support both Hydra and Keycloack in the source code, which you do not mention in the docs. Is that intentional?

Thanks!

@rmmayo
Copy link
Collaborator

rmmayo commented Jan 20, 2025

Hydra is only used for testing, so that was intentionally left out of the docs.

It does look like leaving out keycloak was an oversight. You are welcome to test out keycloak and contribute to the docs if you would like. Thanks!

joshika39 added a commit to joshika39/skills-service that referenced this issue Jan 20, 2025
joshika39 added a commit to joshika39/skills-service that referenced this issue Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants