Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizing "navs" property @grid-float-breakpoint #16

Open
jarstorm opened this issue Nov 6, 2014 · 4 comments
Open

Customizing "navs" property @grid-float-breakpoint #16

jarstorm opened this issue Nov 6, 2014 · 4 comments

Comments

@jarstorm
Copy link

jarstorm commented Nov 6, 2014

I´m trying to customize this property of bootstrap with your package.

My custom.bootstrap.json looks like:

{"modules": {
"navbar": true
}}

I modify the file custom.bootstrap.import.less to put the value:

@grid-float-breakpoint: 1111px;

The generated custom.bootstrap.less looks right but in the final .css file (generated css file for while project) sometimes the property has the value changed and sometimes not.

For example this couple of media queries get the grid-float-breakpoint value correctly:

@media (min-width: 1111px) {
.navbar {
border-radius: 4px;
}
}


@media (min-width: 1111px) {
.navbar-header {
float: left;
}
}

But sometimes it doesn´t work (it has the old value):

@media (min-width: 768px) {
.navbar-collapse {
width: auto;
border-top: 0;
-webkit-box-shadow: none;
box-shadow: none;
}

Thank you.

@Nemo64
Copy link
Owner

Nemo64 commented Nov 8, 2014

I think you are trying to show me an "before and after" but both code snippets are from different parts of bootstrap. Or am I missing something?

Btw. you can use GitHub flavored markdown to make the code more readable. It helps to more quickly see whats code and whats your explanation. ;)

@Nemo64 Nemo64 closed this as completed Nov 8, 2014
@Nemo64 Nemo64 reopened this Nov 8, 2014
@jarstorm
Copy link
Author

jarstorm commented Nov 8, 2014

Hello.

I updated my issue description.

It´s just I´m trying to change this value and in the final css file the property it´s not changed everywhere.

Thank you

@Nemo64
Copy link
Owner

Nemo64 commented Nov 8, 2014

thanks, much more easy to read.

Hoever, I can't replicate your issue. I changed @grid-float-breakpoint to 1111px and the generated file seems to be right.

@media (min-width: 1111px) {
  .navbar-collapse {
    width: auto;
    border-top: 0;
    box-shadow: none;
  }

Do you import the bootstrap.less in other files? How do you set the variable?

@jarstorm
Copy link
Author

jarstorm commented Nov 9, 2014

I used your package in a single project and of course I can´t replicate the issue.

However I´m using in my project the following packages:

accounts-password
hckrs:summernote
ian:accounts-ui-bootstrap-3
less
nemo64:bootstrap
peppelg:bootstrap-3-modal
rgoomar:bootstrap-validator
standard-app-packages

If you try with this package combination you can see the issue. I don´t know if some package is overwriting the value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants