Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(matchers): provide matchers for jest #49

Open
davinkevin opened this issue Jun 29, 2018 · 2 comments
Open

feat(matchers): provide matchers for jest #49

davinkevin opened this issue Jun 29, 2018 · 2 comments

Comments

@davinkevin
Copy link

Hi,

Like previously exposed (on twitter), I'm working with Jest on Angular. Are you interested in migrating the current matchers for the Jest world?

I will do a PR if you're ok.

Thanks

@cexbrayat
Copy link
Member

Hi, and thank you for taking the time to open an issue!

We don't use Jest with Angular, so we never tried to use custom matchers with it. If you think it's a good idea, you can try to add them to the library, PR welcome!

Ideally, the logic shared by the Jasmine and Jest matchers should be in common. Maybe a library like https://github.com/JamieMason/add-matchers can help? (I never used it, just found it by googling around, so there are maybe better alternatives).

Anyway, you're welcome to submit a PR and we'll give it a try. Ideally the PR should include a small demo (in the projects/demo application) and some documentation.

@davinkevin
Copy link
Author

Thank for your answer. I will try to do the PR this week 😉 and I'm totally aligned with you about using jasmine matchers or at least share the same code for both jasmine & jest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants