Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add disabled property on TestInput, TestTextarea and TestSelect #101

Merged
merged 1 commit into from
Nov 17, 2018
Merged

feat: add disabled property on TestInput, TestTextarea and TestSelect #101

merged 1 commit into from
Nov 17, 2018
+51 −0

Conversation

jnizet
Copy link
Member

@jnizet jnizet commented Nov 15, 2018

fixes #100

@jnizet jnizet requested a review from cexbrayat November 15, 2018 18:58
@codecov
Copy link

codecov bot commented Nov 15, 2018 •
edited
Loading

Codecov Report

Merging #101 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   97.97%   98.01%   +0.04%     
==========================================
  Files          11       11              
  Lines         297      303       +6     
  Branches       65       65              
==========================================
+ Hits          291      297       +6     
  Partials        6        6
Impacted Files Coverage Δ
projects/ngx-speculoos/src/lib/test-textarea.ts 90% <100%> (+2.5%) ⬆️
projects/ngx-speculoos/src/lib/test-input.ts 94.44% <100%> (+0.69%) ⬆️
projects/ngx-speculoos/src/lib/test-select.ts 90.62% <100%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92da229...b2e77d6. Read the comment docs.

cexbrayat
cexbrayat approved these changes Nov 15, 2018
View reviewed changes
Copy link
Member

@cexbrayat cexbrayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo in docs, good to merge otherwwise 👍

projects/ngx-speculoos/src/lib/test-textarea.ts Outdated
@@ -25,4 +25,11 @@ export class TestTextArea extends TestHtmlElement<HTMLTextAreaElement> {
get value() {
return this.nativeElement.value;
}

/**
* the disabled property of the wrapped select
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

select -> textarea

@jnizet jnizet force-pushed the feat/100-disabled-input-select-textarea branch 2 times, most recently from 8deaa93 to b2e77d6 Compare November 17, 2018 13:59
@jnizet jnizet merged commit b2e77d6 into master Nov 17, 2018
@jnizet jnizet deleted the feat/100-disabled-input-select-textarea branch November 17, 2018 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cexbrayat cexbrayat cexbrayat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add disabled property for inputs, selects, textareas
2 participants
@jnizet @cexbrayat