Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: downgrade compodoc to 1.1.8 because of code block issue on README #147

Merged
merged 1 commit into from
May 31, 2019

Conversation

renaud-dev
Copy link
Contributor

Fixes #146
See issue on the compodoc repository compodoc/compodoc#765

After compodoc downgrade :
image

@codecov
Copy link

codecov bot commented May 31, 2019

Codecov Report

Merging #147 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #147   +/-   ##
=======================================
  Coverage   99.14%   99.14%           
=======================================
  Files          11       11           
  Lines         234      234           
  Branches       60       60           
=======================================
  Hits          232      232           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5573691...240421b. Read the comment docs.

@jnizet
Copy link
Member

jnizet commented May 31, 2019

Good catch! And thanks a lot for the bug analysis an the fix. 👏

@jnizet jnizet merged commit bba2b6b into Ninja-Squad:master May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[doc] Code blocks in documentation are not displayed correctly
2 participants