Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct link to recipe could offer user to login #18

Open
josephguillaume opened this issue Apr 21, 2024 · 1 comment
Open

Direct link to recipe could offer user to login #18

josephguillaume opened this issue Apr 21, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@josephguillaume
Copy link

If I paste a link to a recipe directly in a browser where I am not logged in, I get 404: Not Found with a link to go home.

Instead of going home, logging in, and trying again, it would be useful to be offered to login directly on that page.

This assumes the link is indeed valid - if the user has actually pasted a link from someone else's pod instead of using the viewer, then this wouldn't work. Given that the url does not encode any information about the pod, logging in is probably the only way to tell anyway.

@NoelDeMartin
Copy link
Owner

Hey, thanks for opening an issue!

I think that's good idea, I'll look into it next time I do a release.

For the longer term, though, I'm still not convinced that this approach of having "pretty urls" is the best for Solid Apps. As we discussed in the forum, one alterantive is having the recipe url encoded in the path, so for example instead of /recipes/ramen the path would be /recipes/https%3A%2F%2Fpod.example.com%2Fcookbook%2Framen%23it. That would remove this problem, and the need for a "viewer" altogether. But I'm still not convinced that having "ugly urls" is ultimately better :/.

So yeah, I don't know what I'll do in the end. But I'm still using pretty urls in the work I'm currently doing, so I guess this will continue being a problem.

@NoelDeMartin NoelDeMartin added the enhancement New feature or request label Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants