Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @ethersproject/abi Dependency #6284

Open
pcaversaccio opened this issue Feb 14, 2025 · 1 comment
Open

Remove @ethersproject/abi Dependency #6284

pcaversaccio opened this issue Feb 14, 2025 · 1 comment
Assignees
Labels
status:ready This issue is ready to be worked on

Comments

@pcaversaccio
Copy link
Contributor

In hardhat you have multiple dependencies on @ethersproject/abi, e.g.:

Due to that dependency, you still have to rely on the old elliptic and vulnerable version GHSA-vjh7-7g9h-fjfh through ethers sub-dependency on @ethersproject/signing-key. The TL;DR is that if wallets strictly follow RFC-6979 (nonces are derived deterministically from the hashed message) and doesn't allow custom nonce injection, everything should be safe. In any case, it would be nice to remove this dependency and switch over to ethers v6 if possible. Thoughts?

@kanej
Copy link
Member

kanej commented Feb 14, 2025

Thanks for bringing this up. We should switch to the newer version.

@kanej kanej added status:ready This issue is ready to be worked on and removed status:triaging labels Feb 14, 2025
@kanej kanej assigned schaable and unassigned galargh Feb 14, 2025
@kanej kanej moved this from Backlog to To-do in Hardhat Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready This issue is ready to be worked on
Projects
Status: To-do
Development

No branches or pull requests

4 participants