Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignition follow up #6292

Open
1 of 34 tasks
kanej opened this issue Feb 14, 2025 · 0 comments
Open
1 of 34 tasks

Ignition follow up #6292

kanej opened this issue Feb 14, 2025 · 0 comments
Labels
status:ready This issue is ready to be worked on type:epic A bigger effort that involves multiple issues and PRs v-next A Hardhat v3 development task

Comments

@kanej
Copy link
Member

kanej commented Feb 14, 2025

Ignition has been ported to Hardhat 3. There is significant follow up work from that process:

TODO

ignition-core

  • Re-enable integration tests (deal with Hardhat project fixtures)
  • Port Ignition Errors to Hardhat 3
  • Update codebase so no eslint rules are disabled
  • Port lodash calls to hardhat-utils
  • Port address related calls to hardhat-utils
  • Port ethers calls to hardhat-utils
  • Update imports of ./src/index.js to be more specific (we should avoid relying on
    index.js files)
  • Re-enable npm scripts comparison check in CI (we need to wait until Node Test Runner move is complete).
  • Look again at chai and chai types versions, I tried bumping up the version to match Ignition and ended up moving it down to match hardhat-chai-matchers

ignition-ui

  • Remove eslint opt outs and make it work
  • Fix display of mermaid graph details in visualizer

hardhat-ignition

  • Rework Ignition UI to be based off of the HH3 hook api
  • Rewire the ledger checks to work with user interruptions
  • Hook in verify on Ignition
  • Review config setup
  • Revisit test fixture setup - can we improve on performance with precompiled artifacts
  • Deal with task default values like deploymentId where currently we are using "" to represent no option given by user
  • Convert tests to Node Test Runner
  • Get rid of hardhat_setLedgerOutputEnabled - Method not supported message on the node
  • Re-enable all eslint rules
  • Add an integration test to ensure that if the user sets the ignition path, that is coming through in the config
  • Revisit the visualization test - it requires a vite build of the ui which significantly slows down the dev flow of testing
  • Revisit the odd default network connection usage in transactions
  • We will revisit the type exports after the initial public alpha
  • We should change the network name check, to a check on network type - EDR networks are ephemeral

hardhat-ignition-viem

  • Convert tests to Node Test Runner
  • Remove exemptions from eslint rules
  • Look again at type checks in tests - can this be made more comprehensible in terms of build steps
  • Remove npm scripts comparison exemption
  • Consider using a config validation rule rather than the other plugin check directly in the network connection hook

hardhat-ignition-ethers

  • Add typechain support
  • Convert tests to Node Test Runner
  • Remove npm scripts comparison exemption
  • Switch to dynamic imports for plugin dependencies in ./src/index.ts
@kanej kanej added type:epic A bigger effort that involves multiple issues and PRs v-next A Hardhat v3 development task labels Feb 14, 2025
@kanej kanej added this to the Public Alpha Feature Rollout milestone Feb 14, 2025
@kanej kanej added this to Hardhat Feb 14, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Hardhat Feb 14, 2025
@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Feb 14, 2025
@kanej kanej moved this from Backlog to To-do in Hardhat Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready This issue is ready to be worked on type:epic A bigger effort that involves multiple issues and PRs v-next A Hardhat v3 development task
Projects
Status: To-do
Development

No branches or pull requests

1 participant