Change the ESM init message wording #6325
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
galargh
approved these changes
Feb 19, 2025
| @@ -33,7 +33,7 @@ export async function promptForMigrateToEsm( | |||
| { | |||
| name: "migrateToEsm", | |||
| type: "confirm", | |||
| message: `Hardhat only supports ESM projects. Would you like to set the type for ${shortenPath(absolutePathToPackageJson)} to "module" now?`, | |||
| message: `Hardhat only supports ESM projects. Would you like to change your package.json "${shortenPath(absolutePathToPackageJson)}" to turn your project into ESM?`, | |||
There was a problem hiding this comment.
As @ChristopherDedominici pointed out, after the fix from #6326, we would get duplicate package.json in the message. I'm going to apply this suggestion and then queue the PR for merge.
Suggested change
| message: `Hardhat only supports ESM projects. Would you like to change your package.json "${shortenPath(absolutePathToPackageJson)}" to turn your project into ESM?`, | |
| message: `Hardhat only supports ESM projects. Would you like to change your "${shortenPath(absolutePathToPackageJson)}" to turn your project into ESM?`, |
There was a problem hiding this comment.
Or not, I'll create a new PR since I cannot remove this one from the merge queue 🤦
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.