Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADT: Normalize representatives in assume #1096

Closed
bclement-ocp opened this issue Apr 22, 2024 · 0 comments · Fixed by #1100
Closed

ADT: Normalize representatives in assume #1096

bclement-ocp opened this issue Apr 22, 2024 · 0 comments · Fixed by #1100
Assignees
@Halbaroth

Comments

@bclement-ocp
Copy link
Collaborator

Following #1087 I believe the assume_literals function is incorrect: it should call Uf.find_r on all semantic values that appear in the literals.

Semantic values that appear in the literals given to assume are not guaranteed to be in normal form, even though they usually are: during CC(X) resolution I believe it is possible to generate a literal such as x = y then later pick a new representative for y or x. I have seen this happen with bit-vectors; presumably it can also happen with ADTs.

(Sorry, I missed it during review!)
Halbaroth added a commit to Halbaroth/alt-ergo that referenced this issue Apr 29, 2024
@Halbaroth
Normalize ADT in assume
a0815f9 
Fix issue OCamlPro#1096
@Halbaroth Halbaroth mentioned this issue Apr 29, 2024
Merged
@Halbaroth Halbaroth linked a pull request Apr 30, 2024 that will close this issue
Normalize ADT in assume #1100
Merged
Halbaroth added a commit that referenced this issue May 10, 2024
@Halbaroth
Normalize ADT in assume (#1100)
b464ec3 
* Normalize ADT in `assume`

Fix issue #1096
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Halbaroth Halbaroth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Normalize ADT in assume Halbaroth/alt-ergo
2 participants
@Halbaroth @bclement-ocp