Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Crash if number is sent as value to addAlias #1016

Open
2 of 3 tasks
fmp777 opened this issue Aug 21, 2024 · 0 comments
Open
2 of 3 tasks

[Bug]: Crash if number is sent as value to addAlias #1016

fmp777 opened this issue Aug 21, 2024 · 0 comments

Comments

@fmp777
Copy link

fmp777 commented Aug 21, 2024

What happened?

Crashes on IOS (not sure about Android) when a number is sent instead of a string in the value of addAlias. Typecasting values to string before sending to OneSignal sdk resolves the crash.

image

Steps to reproduce?

1. Install the plugin (latest)
2. during app init, call `OneSignal.User.addAlias('myalias', 123);`
3. observe IOS crash

What did you expect to happen?

I expect onesignal plugin to typecast values to string (especially if is integer). If some other non-stringable value, throw error instead of executing a crash.

OneSignal Cordova SDK version

5.2.3 & 5.2.4

Which platform(s) are affected?

  • iOS
  • Android

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant