Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Cannot add device with device_type = 0 #15

Open
1 task done
phuongvd201 opened this issue Aug 25, 2022 · 3 comments
Open
1 task done

[Bug]: Cannot add device with device_type = 0 #15

phuongvd201 opened this issue Aug 25, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@phuongvd201
Copy link

What happened?

Cannot add device with device_type = 0

Steps to reproduce?

1. call CreatePlayerAsync with DeviceType = 0
2. Error return {\"errors\":[\"device_type is required\"]}

What did you expect to happen?

Be able to create device with device_type = 0

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@phuongvd201 phuongvd201 added the bug Something isn't working label Aug 25, 2022
@phuongvd201
Copy link
Author

phuongvd201 commented Aug 31, 2022

image
I believe that DeviceType with integer datatype and IsRequire attribute, So the value = 0 does NOT pass the validation

@rer145
Copy link

rer145 commented Nov 3, 2022

I am experiencing the same issue on my end. Worked before in July, but stopped working sometime in August.

I did a manual post to the REST api with the same parameters (using 0 for device_type) and it succeeded.

@rer145
Copy link

rer145 commented Nov 3, 2022

I dug into the code and changes some more. It looks like PR #12 fixed the issue (setting EmitDefaultValue to true), and was merged in, but no release has been made with that change.

PR #12 was merged September 1, but the last release is from August 4th.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants