Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/tcp should return "output": "json" only if it's sending json #75

Open
produceconsumerobot opened this issue Apr 5, 2018 · 2 comments
Open

/tcp should return "output": "json" only if it's sending json #75

produceconsumerobot opened this issue Apr 5, 2018 · 2 comments
Labels
bug help wanted

Comments

@produceconsumerobot
Copy link

No description provided.

@jnaulty
Copy link
Contributor

jnaulty commented Apr 6, 2018

@produceconsumerobot
do you have steps to reproduce this bug?

I'd like to look into it more.

@andrewjaykeller
Copy link

@jnaulty so you know how I had to drop support for json by default on the latest default firmware? well you can still set the mode to JSON and get no error, we should return an error if user sets json mode and we can't actually do JSON

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@produceconsumerobot @jnaulty @andrewjaykeller