Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation Error Border Missing for Content Picker #17462

Open
SndpAST opened this issue Feb 7, 2025 · 4 comments · May be fixed by #17470
Open

Validation Error Border Missing for Content Picker #17462

SndpAST opened this issue Feb 7, 2025 · 4 comments · May be fixed by #17470

Comments

@SndpAST
Copy link

SndpAST commented Feb 7, 2025

Describe the bug

In Orchard Core 2.1.5, the validation error styling for required fields is inconsistent across different field types. While text and date fields correctly display a red border when validation fails, the Content Picker field does not show the error border when it is required but left empty.

Orchard Core version

2.1.5

To Reproduce

  • Add a Content Picker field to a Content Type.
  • Mark the field as Required in its settings.
  • Create a new Content Item of this type and leave the Content Picker field empty.
  • Try to save the form.

Expected behavior

  • The Content Picker field should display a red error border similar to text and date fields when validation fails.

Logs and screenshots

Image

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Thank you for submitting your first issue, awesome! 🚀 We're thrilled to receive your input. If you haven't completed the template yet, please take a moment to do so. This ensures that we fully understand your feature request or bug report. On what happens next, see the docs.

@hishamco
Copy link
Member

hishamco commented Feb 8, 2025

@SndpAST are you going to submit a PR for it?

@Piedone Piedone added the ui/ux label Feb 9, 2025
@Piedone
Copy link
Member

Piedone commented Feb 9, 2025

This is indeed an issue. I guess it's because while the other two are simple text inputs, the Content Picker is not, and thus needs specific support for this.

@hishamco
Copy link
Member

hishamco commented Feb 9, 2025

I will wait until tomorrow for @SndpAST if he didn't reply I will might take this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants