Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration Change Sync blocking Call #syncAfterConfigurationChange #11408

Closed
PedroMPagani opened this issue Sep 16, 2024 · 0 comments
Closed

Comments

@PedroMPagani
Copy link

Profile link

not necessary

Description of issue

Instead of calling a sync blocking call from the connection, instead maybe implement a "state" where until the packet listener was a succes, to not flush the queues ("write to the connection"), this way there is not a full risk of an mspt spike due to this call, in which in some cases, it'll happen very often.

The method is #syncAfterConfigurationChange
I'm mainly only opening the issue to report the case, unfortunately I don't think I can open a PR, maybe someone can if paper team thinks this is a valuable add.

Plugin and Datapack List

code

Server config files

Paste configs or paste.gg link here!

Paper version

code

Other

code

@PedroMPagani PedroMPagani changed the title Configuration Change Sync blocking Call Configuration Change Sync blocking Call #syncAfterConfigurationChange Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants