Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure contains a bunch of stuff about drand48 which it need not #23023

Open
demerphq opened this issue Feb 24, 2025 · 1 comment
Open

Configure contains a bunch of stuff about drand48 which it need not #23023

demerphq opened this issue Feb 24, 2025 · 1 comment
Assignees

Comments

@demerphq
Copy link
Collaborator

demerphq commented Feb 24, 2025

Description
We have bundled our own Drand48 for a long time. We should not have any logic in Configure regarding this as it is redundant.

We probably should get rid of randbits and RANDBITS as well. I cant see any use of them that isn't a bad idea.

This also applies to srand48, and random and srandom. Basically Configure shouldnt be concerning itself with random functions from the OS, it should just hard code the internal implementation we provide.

Steps to Reproduce
N/A

Expected behavior
Configure shouldnt probe for Drand48 or any other RNG.

Perl configuration
This is true as of perl 5.41.9 at least.

@scottchiefbaker
Copy link
Contributor

I've spent too much time in Configure lately, so I totally understand. RANDBITS is a relic and can (and should be) removed. I think this needs to stay:

drand01="Perl_drand48()"

I can't find the reference right now, but I believe some compilers take drand01 as a compile time override for the internal C rand() function. Not sure we if we use that but we might want to investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants