Fixing "next match" feature #1498
Conversation
trying to fix issue 1480
Scores don't upload quickly, so this appears to fix the issue. Also ran lint.
|
Hey @varCepheid, usually the scheduled match time and the predicted match time are wrong by 5-10 minutes. Do you think that instead of this solution we could show "upcoming matches" as 2-3 matches? |
… before and three after the current time; in fixing some aestethic issues a couple more popped up, but I don't know exactly how to fix those (and they're a bit less noticeable)
|
I think the problem has been solved, though a bit of tweaking may be useful so that it looks neat (the Upcoming Matches header is off-center, even though it says justify-self: center; and the search bar sits right on top of Qual 1). |
|
Hey @ev118, thanks for updating this! I think there are several opportunities to simplify the approach here, would you be open to scheduling a meeting this weekend to work through that with me? |
…real events so it needs checking. --Elijah
varCepheid
added
bug
…regrine-frontend into fixing-next-match
varCepheid
removed
the
needs work
|
@varCepheid can you delete commented-out code from this PR? Generally it is good practice to try to avoid committing commented-out code to dev/main branches. |
calebeby
added
the
needs work
varCepheid
removed
the
needs work
|
calebeby
added
the
needs work
| <> | ||
| <h2 class={sectionStyle}>Next Match</h2> | ||
| <MatchDetailsCard match={nextMatch} eventKey={eventKey} link /> | ||
| <Heading level={2}>Upcoming Matches</Heading> |
There was a problem hiding this comment.
This is a little nitpicky, but the space between the "upcoming matches" heading and the actual match cards is half the size of the space between the other elements on the page.
Before this PR:
After this PR:
The new heading looks nice in terms of the underline and text styling, but it feels a little bit cramped without the even space around it.
|
@varCepheid I also noticed that the issue #1493 is kind of vague and doesn't mention whether it is talking about the next match feature on the team@event page or on the event page. This PR only fixes the team@event page, so maybe we should leave that issue open when this is merged and open another PR for the event page. |
removed "No Upcoming Matches" on event-team page added space below header changed getUpcomingMatches to new series of filters
|
I agree that the issue is vague. I added a description on the PR, which is hopefully more clear. And the changes here do affect the event page; if it wasn't doing anything different, we should definitely fix that here. |
varCepheid
removed
the
needs work
|
When I merged from |
|
@varCepheid sorry for not getting back to you sooner. You shouldn't ever need to manually merge a |
closes #1493
At the top of the event and event-team pages, instead of one "next match," the page shows the three most relevant upcoming matches.