Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lottie added #280

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Lottie added #280

wants to merge 2 commits into from
+41 −5

Conversation

Sakshamjain98
Copy link
Contributor

Fixes Issue🛠️

Closes #255

Description👨‍💻

Fixed the issue where the Lottie animation was shifting due to the dynamic width of the TypingEffect component. Applied a fixed width and height to the Lottie container and added flex-shrink-0 to ensure it remains unaffected by text changes.

Type of Change📄

  • Bug fix (non-breaking change which fixes a bug)
  • New feature (non-breaking change which adds functionality)
  • Style (non-breaking change which improves website style or formatting)
  • Documentation (non-breaking change which updates or adds documentation)
  • Responsiveness (non-breaking change which improves UI/UX on different screen sizes)

Checklist✅

  • I am an Open Source contributor
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented on my code, particularly in hard-to-understand areas
  • I have installed packages from frontend folder by npm ci instead of npm i

Screenshots/GIF📷

Screen.Recording.-.Made.with.FlexClip.23.webm

@vercel Vercel
Copy link

vercel bot commented Feb 11, 2025

@Sakshamjain98 is attempting to deploy a commit to the Pratik0112's projects Team on Vercel.

A member of the Team first needs to authorize it.

github-actions[bot]
github-actions bot reviewed Feb 11, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Sakshamjain98, Welcome to 💖TelMedSphere !!! 🎊
Thanks for raising a PR! Your effort makes this project better. 🙌
Please wait for the PR to be reviewed.
Happy Coding!! ✨

@vercel Vercel
Copy link

vercel bot commented Feb 11, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pratik0112-telmedsphere ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 2:00pm

@PratikMane0112
Copy link
Owner

@Sakshamjain98, can you please add the original image instead of this image & keep rest bg animation same

  • remove this doctors image

image

  • add below image

image

And keep the rest bg animation same

@Sakshamjain98
Copy link
Contributor Author

Its not possible to replace the image instead i can change the lottie file

@PratikMane0112
Copy link
Owner

Its not possible to replace the image instead i can change the lottie file

ok the go for it

@Sakshamjain98
Copy link
Contributor Author

Should i have to change the lottie file or
U are merging it?

@PratikMane0112
Copy link
Owner

Change the lottie file but keep the base image same & rest animation you like

@PratikMane0112
Copy link
Owner

This one

image

@Sakshamjain98
Copy link
Contributor Author

Okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
🚨 change suggested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Style] Want to Improve by adding moving element lottie type
2 participants
@Sakshamjain98 @PratikMane0112