Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support BraveAIChatEnabled setting for Brave Browser #694

Closed
securitygeneration opened this issue Sep 3, 2024 · 9 comments · Fixed by #700
Closed

Support BraveAIChatEnabled setting for Brave Browser #694

securitygeneration opened this issue Sep 3, 2024 · 9 comments · Fixed by #700
Assignees
Labels
🛠️ update manifest Update existing manifest

Comments

@securitygeneration
Copy link

Please provide the following information:

Name of App / Payload: ex. Firefox OR org.mozilla.firefox

com.brave.Browser

Preference key(s) to be added / updated: ex. AppUpdateURL, Bookmarks, etc.

BraveAIChatEnabled

Applicable Preference Documentation URL(s):

https://support.brave.com/hc/en-us/articles/360039248271-Group-Policy

Options 0 or 1 (default 1)

@securitygeneration securitygeneration added the 🛠️ update manifest Update existing manifest label Sep 3, 2024
@relgit relgit self-assigned this Sep 4, 2024
relgit added a commit to DigiDNA/ProfileManifests that referenced this issue Sep 4, 2024
…toreOnStartupURLs` on the Chromium-based manifests. Also, added `BraveAIChatEnabled` to the Brave manifest, which closes ProfileCreator#694
@relgit relgit closed this as completed in f302872 Oct 7, 2024
@securitygeneration
Copy link
Author

securitygeneration commented Oct 8, 2024

@relgit looks like this isn't working. This attribute expects an actual true/false boolean. Setting an integer results in an error

image

Thanks for taking the time to implement this :)

@relgit
Copy link
Collaborator

relgit commented Oct 10, 2024

@securitygeneration have you tested it to work with an actual boolean?

@securitygeneration
Copy link
Author

I confess I don't know how, so I haven't tried. Can look into it by copying a Boolean from another attribute if you want.

@relgit
Copy link
Collaborator

relgit commented Oct 10, 2024

It's quite easy actually, assuming that your profile is not signed.

Open the profile in a text editor, and locate the BraveAIChatEnabled property key. Below the key you'll find the value, which for now will probably be <integer>0</integer>. Change the value to <false/> and save the profile. Then, install the modified profile on your machine and check again in the policy console.

@securitygeneration
Copy link
Author

securitygeneration commented Oct 11, 2024

Ohh, you mean in the final profile. Of course how dumb of me. I thought you meant in the ProfileCreator files directly.

Yes, changing it to false works. In fact there are three attributes (at least, as far as I could find) currently set to 0|1 by ProfileCreator/iMazing which error and need to be changed to Boolean:

  • BraveAIChatEnabled
  • BraveVPNDisabled; and
  • TorDisabled
image

@securitygeneration
Copy link
Author

@relgit it seems I can't reopen this ticket, could you update the manifest to use a Boolean for these keys?

@relgit
Copy link
Collaborator

relgit commented Oct 14, 2024

Thanks for testing @securitygeneration; what an interesting catch.

This got me questioning the whole Brave documentation page, and luckily the browser is open sourced so we can examine the code where these preferences are actually defined:
https://github.com/brave/brave-core/blob/master/browser/policy/brave_simple_policy_map.h

And what do you know? The documentation page is really messed up because there is not a single integer in sight.

So we should definitely update the manifest, but to keep things clean I'll open a new issue.

@securitygeneration
Copy link
Author

Maybe I'll try reporting the documentation flaws to the Brave project

@relgit
Copy link
Collaborator

relgit commented Oct 14, 2024

That would be helpful.

relgit added a commit that referenced this issue Oct 16, 2024
* The Nudge manifest updated for version 2.0

* Adjustment to the Nudge manifest following documentation update

* Updated the default value of `utilizeSOFAFeed` to match the release notes

* The SupportApp manifest updated for version 2.6

* Further updates to the Nudge manifest. No version bump because manifest not merged since last bump.

* Incorrect key name in the Nudge manifest fixed

* Added missing keys and updated descriptions in the Exchange Web Services manifest

* Anonymous subkeys in the MDM manifest gained names

* Updated array subkey name in the AirPrint manifest to match the documentation

* Further array subkeys in a variety of manifests had their names updated or added where missing to match the documentation

* The subkey `RegistrationToken` in the Extensible SSO manifest moved and gained another exclusion target condition

* Indicated the removal of `RequiredAndOptionalData` from the `AcknowledgedDataCollectionPolicy` property in the Microsoft Auto Update manifest

* Updates to the Restrictions manifests including missing subkeys, introduction and deprecation versions, corrected default values, supervision, anonymous subkey naming, and value ranges

* Fixed dangling value

* Key `IgnoreMiddleware` added to the Munki manifest. Fixes #693

* The new `IgnoreMiddleware` added to another segment in the Munki manifest

* Missing keys added to the OneDrive manifest

* Added missing keys in the top level manifest

* Major OS version updates to several manifests

* Further major OS version updates

* Title updated on the Setup Assistant manifest

* Reordered the Setup Assistant manifest to deprioritize deprecated properties

* Added a case to `RestoreOnStartup` and an exclusion condition to `RestoreOnStartupURLs` on the Chromium-based manifests. Also, added `BraveAIChatEnabled` to the Brave manifest, which closes #694

* Added one more key in the Setup Assistant manifest

* Removed unnecessary line breaks in the Microsoft Office manifest

* Added note to `AcceptEAPTypes` from #234

* Add `pfm_range_list_titles` array for `SystemModeCredentialsSource` to have the more friendly 'Active Directory' option listed as in #234

* Removed `Interface` preference since the options are only related to ethernet connections, as in #234

* In the extensible SSO manifest, removed fixed requirement that is the result of merging the Kerberos and non-Kerberos manifests and replaced it with conditional. Also, added exclusion according to the documentation.

* Most recent major OS version updates on several manifests

* Further most recent major OS version updates

* Two new skip keys added to the Setup Assistant manifest

* Cleaned up leftover from recent changes in the Restrictions manifest

* Default value type updated to reflect same type of its property

* Added new description to the Setup Assistant manifest

* Remove subkeys definition from `ProviderConfiguration` in the DNS Proxy manifest due to the custom dictionary value being any type, which is currently not supported in the repository
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ update manifest Update existing manifest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants