Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dependabot automatic fixing of dependencies for improved security #1749

Open
jamesobutler opened this issue Oct 10, 2024 · 4 comments

Comments

@jamesobutler
Copy link
Contributor

jamesobutler commented Oct 10, 2024

Enable dependabot in the security section of this repo. https://github.com/Project-MONAI/MONAILabel/settings/security_analysis
cc: @SachidanandAlle

With these settings turned on (see image below) you will see dependabot alerts such as:

With the setting to enabled to allow dependabot to automatically open PRs, you will observe that it will open a PR such as:

{57049627-E9E9-4AAF-A1E7-DDB2874C332B}

@jamesobutler
Copy link
Contributor Author

@SachidanandAlle Does this sound reasonable to improve the security for MonaiLabel? This usage of dependabot uses automation to reduce the amount of human interaction required to stay on top of updates.

@SachidanandAlle
Copy link
Collaborator

yes. makes sense :)

@SachidanandAlle
Copy link
Collaborator

SachidanandAlle commented Oct 14, 2024

one issue that needs to be fixed/resolved once we enable the dependency bot- keep both requirements.txt and setup.py in sync.

may be there is way to fix this dedup problem.

@jamesobutler
Copy link
Contributor Author

Based on https://packaging.python.org/en/latest/discussions/install-requires-vs-requirements/ it appears that requirements.txt and install_requires of setup.cfg serve different purposes. The setup.cfg should contain the minimal set of requirements (non hard-pinned) while requirements.txt can contain pinned dependencies for repeatable installations. So the need for them to be the exact same appears to be unnecessary based on the python organization's guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants