Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Attributes support in Acorn #1218

Open
3 tasks
thescientist13 opened this issue Apr 12, 2024 · 1 comment · May be fixed by #1321
Open
3 tasks

Import Attributes support in Acorn #1218

thescientist13 opened this issue Apr 12, 2024 · 1 comment · May be fixed by #1321
Assignees
Labels
CLI enhancement Improve something existing (e.g. no docs, new APIs, etc) v0.31.0
Milestone

Comments

@thescientist13
Copy link
Member

thescientist13 commented Apr 12, 2024

Summary

Playing the long game a bit, but as Import Attributes are only currently Stage 3, it is not supported in some key dependencies yet, like acorn. (made a little repro repo to confirm)

However, it is supported in NodeJS and browsers as was implemented in #923 and ProjectEvergreen/wcc#157.

Will also want to track this along with an upgrade to latest Rollup, which actually took out the ability to pass in custom Acorn plugins - #1087 (comment)

Details

As part of those PRs for Greenwood and WCC, a community plugin was used to bridge the gap, however when the spec graduates to Stage 4 and / or acorn adopts it, we can / should (for both WCC and Greenwood):

  1. Upgrade acorn version
  2. Will probably need to rollback custom parser changes
  3. Remove the dependency on acorn-import-attributes
@thescientist13
Copy link
Member Author

thescientist13 commented Nov 2, 2024

Seems like this might be available now!
https://github.com/acornjs/acorn/blob/master/acorn/CHANGELOG.md#8140-2024-10-27

@thescientist13 thescientist13 self-assigned this Nov 2, 2024
@thescientist13 thescientist13 moved this from 🔖 Ready to 🏗 In progress in [Greenwood] Phase 10 - Ecosystem Compat Nov 14, 2024
@thescientist13 thescientist13 linked a pull request Nov 14, 2024 that will close this issue
5 tasks
@thescientist13 thescientist13 moved this from 🏗 In progress to 👀 In review in [Greenwood] Phase 10 - Ecosystem Compat Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI enhancement Improve something existing (e.g. no docs, new APIs, etc) v0.31.0
Projects
Status: 👀 In review
Development

Successfully merging a pull request may close this issue.

1 participant