Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team sync December 11, 2023 #51

Open
5 of 6 tasks
gabalafou opened this issue Dec 11, 2023 · 2 comments
Open
5 of 6 tasks

Team sync December 11, 2023 #51

gabalafou opened this issue Dec 11, 2023 · 2 comments

Comments

@gabalafou
Copy link
Contributor

gabalafou commented Dec 11, 2023

Sync between Smera and Gabriel.

Notes, decisions made

  • Open question: how are we going to make public the PyData Sphinx Theme design system?
  • Smera is working on dark mode for tables: Improve PyData libraries table styling #50
  • Decisions made for header nav icon right side icons:
    • They should all have square focus rings
    • The PyData logo should be like the others
  • Decision for hover state on the open buttons for the version switcher and the more dropdown: keep text color the same but brighten/darken it
  • It's possible to move focus to the back to top button when tabbing away from the version warning button (Switch to stable version)
    • Gabriel: because of this, I'm going to leave the focus ring that I already added, looks like this: back to top button focus ring has the same pill shape and color as the button, with slight gap or offset from the edge of the button
  • Smera on PTO Wednesday-Friday.

Action items:

  • Gabriel to ask Tania if there is a grayscale version of the PyData logo somewhere
  • Smera will check the links in the "More" dropdown to make sure contrast on hover is okay
  • Smera to give some time to think about the hover states for the open buttons for the version switch and the more dropdown
  • Black text on orange button: needs further investigation
  • Tania to look at the header nav (#1545) preview build
  • Gabriel to hunt for other buttons on the PST documentation site
@trallard
Copy link
Member

Black text on orange button: needs further investigation

This is a very very low priority - text/background on orange so let's not focus on this @smeragoel

@trallard
Copy link
Member

21st December

@gabalafou todo:

  • Collapsible admonitions (toggle button): change chevron (up/down) and add click to collapse text (see Figma)
  • @trallard to review opened PRs and merged
  • Last three items in List of focus ring aberrations #49 will be dealt with separately

@smeragoel

  • Will work on the design for outline buttons
  • Tables!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📬 TODO
Development

No branches or pull requests

2 participants