Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated checks #55

Open
5 tasks
Tracked by #54
smeragoel opened this issue Feb 7, 2024 · 2 comments
Open
5 tasks
Tracked by #54

Automated checks #55

smeragoel opened this issue Feb 7, 2024 · 2 comments

Comments

@smeragoel
Copy link

smeragoel commented Feb 7, 2024

👥🪪 duplicate-id-aria:

duplicate-id-aria: IDs used in ARIA and labels must be unique - WCAG 4.1.1

  • Instance 1

    • Path
      .me-auto > .navbar-item:nth-child(1) > .version-switcher__container.dropdown > .version-switcher__button[role="button"][aria-haspopup="listbox"]

    • Snippet

    <button id="versionswitcherbutton" type="button" role="button" class="version-switcher__button btn btn-sm navbar-btn dropdown-toggle" data-bs-toggle="dropdown" aria-haspopup="listbox" aria-controls="versionswitcherlist" aria-label="Version switcher list" data-active-version-name="dev" data-active-version="dev">
  • Instance 2

    • Path
      .me-auto > .navbar-item:nth-child(1) > .version-switcher__container.dropdown > .version-switcher__menu.list-group-flush.py-0

    • Snippet

     <div id="versionswitcherlist" class="version-switcher__menu dropdown-menu list-group-flush py-0" role="listbox" aria-labelledby="versionswitcherbutton">
  • Instance 3

    • Path
      .me-auto > .navbar-item:nth-child(2) > nav > .bd-navbar-elements.navbar-nav > .dropdown.nav-item > .dropdown-menu

    • Snippet

    <ul id="pst-header-nav-more-links" class="dropdown-menu">

🔗 link-name

link-name: Links must have discernible text - WCAG 2.4.4, WCAG 4.1.2

  • Instance 1

    • Path
      .sd-stretched-link.external[href$="pydata.html"]

    • Snippet

    <a class="sd-stretched-link reference external" href="examples/pydata.html"></a>
  • Instance 2

    • Path
      .sd-stretched-link.external[href$="gallery.html"]

    • Snippet

     <a class="sd-stretched-link reference external" href="examples/gallery.html"></a>
@gabalafou
Copy link
Contributor

I think there are PRs that address everything in this issue.

Is there a way to mark this issue as "probably done, let's check once all of my PRs have been merged"?

@smeragoel
Copy link
Author

Hmm, I don't think we have a label for that 😹 Let's link those PRs here, and we will come back to this when they are merged. Your comment should be mroe than enough to remind us to double check!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📬 TODO
Development

No branches or pull requests

3 participants