Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[🐞] v2: doesn't handle missing/added fragments well #7033

Open
wmertens opened this issue Nov 1, 2024 · 0 comments
Open

[🐞] v2: doesn't handle missing/added fragments well #7033

wmertens opened this issue Nov 1, 2024 · 0 comments
Assignees
@Varixo
Labels
COMP: runtime TYPE: bug Something isn't working VERSION: upcoming major

Comments

@wmertens
Copy link
Member

wmertens commented Nov 1, 2024

Which component is affected?

Qwik Runtime

Describe the bug

when vnodes are tree shaken, or a component returns a fragment where there wasn't any, the consolidation of jsx output vs existing vnodes will recreate existing vnodes instead of moving them inside the fragment.

Reproduction

in varixo's head ;)

Steps to reproduce

No response

System Info

v2

Additional Information

No response
@wmertens wmertens moved this from Backlog to In progress in Qwik Development Nov 1, 2024
@Varixo Varixo moved this from In progress to Waiting For Review in Qwik Development Nov 9, 2024
@Varixo Varixo moved this from Waiting For Review to In progress in Qwik Development Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Varixo Varixo

Labels
COMP: runtime TYPE: bug Something isn't working VERSION: upcoming major
Projects
Qwik Development
Status: In progress
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wmertens @Varixo