Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[🐞] v2: serializes too much #7034

Open
2 tasks
wmertens opened this issue Nov 1, 2024 · 0 comments
Open
2 tasks

[🐞] v2: serializes too much #7034

wmertens opened this issue Nov 1, 2024 · 0 comments
Assignees
@wmertens
Labels
COMP: runtime TYPE: bug Something isn't working VERSION: upcoming major

Comments

@wmertens
Copy link
Member

wmertens commented Nov 1, 2024

Which component is affected?

Qwik Runtime

Describe the bug

when serializing, v2 will capture all vnodes as well as all effect functions.

  • VNode tree shaking is being implemented in perf(serdes): vnode tree shaking #6963
  • Effect serde still needs to be optimized. This is what causes the "cannot serializes function, ignoring for now" messages

Reproduction

no

Steps to reproduce

No response

System Info

v2

Additional Information

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wmertens wmertens

Labels
COMP: runtime TYPE: bug Something isn't working VERSION: upcoming major
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wmertens