Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bugs for line and bar charts + minor changes #206

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

theperu
Copy link
Collaborator

@theperu theperu commented Feb 3, 2025

[#204 and #205 ] Fixing bugs for line and bar charts + minor changes

🎯 Purpose

  1. Fixing the charts bugs
  2. Removing unused account modal
  3. Updated Federico's link in the Contributors page

📱 Changes Made

This PR contains the following changes:

  • Fixed line chart empty spots issue by adding the option to backfill the data provided to the widget
  • Fixed the average shown in the bar chart, now it looks for the first month of tracking as a starting point and divides by the month that passed since instead of always dividing by 12
  • Deleted account_modal.dart since is not used in the app
  • Updated Federico's link to his portfolio instead of his GitHub

🧪 Testing Instructions

🔍 Review Checklist

  • Code follows project style guidelines
  • Documentation updated (if needed)
  • Widgets are properly disposed

@mikev-cw
Copy link
Collaborator

mikev-cw commented Feb 6, 2025

Good job, looks good to me!

Just one quick issue: line_chart_test.dart is failing.

    Actual: _TextWidgetFinder:<Found 0 widgets with text "29": []>
     Which: means none were found but one was expected

I think it's just because we don't have 29 days on this month 😅
Just remove that line, or replace with 28.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants