Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve testing #151

Open
5 tasks
gonsie opened this issue May 7, 2019 · 5 comments
Open
5 tasks

improve testing #151

gonsie opened this issue May 7, 2019 · 5 comments

Comments

@gonsie
Copy link
Member

gonsie commented May 7, 2019

There are a number of task that should be done to improve the testing:

  • improve the setup of the Travis tests. This should involve using multiple build stages and conditional stages to test various compilers and deploy the doxygen.
  • improve how we leverage PHOLD to test various features. There should be a distinction between an instrumented phold version which can do all the things and the original phold benchmark (I'm not sure if one model code base can/should capture both of these concepts.)
  • through the improvements to a feature-rich phold test, improve our test coverage.
  • improve the cmake for generating coverage (refactor for bugs uncovered in see if gcov and clang versions match #150)
  • improve the cmake for running tests. Right now mpirun -np is hard-coded, but it doesn't need to be.
@caitlinross
Copy link
Member

To add on to this, coverage decreased quite a bit with the merge of #149. I decided to go ahead and merge it anyway and we can work on improving coverage with the rest of these tasks.

@caitlinross
Copy link
Member

caitlinross commented Jun 13, 2019

FYI, next month Kitware is having a CMake tutorial day. Neil and I are both going, so I plan to work work on making some more improvements to our CMake files and testing around then (plus I should be done with my thesis by then).

@laprej
Copy link
Member

laprej commented Jul 11, 2019

Any updates on this? Did you guys learn any cool tips and tricks with CMake? :)

@caitlinross
Copy link
Member

Not yet. The CMake tutorial is on the 23rd! Maybe they still have some seats open if you want to attend.

@laprej
Copy link
Member

laprej commented Jul 11, 2019

Excellent, I registered, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants